From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from [192.168.88.254] (unknown [125.160.106.238]) by gnuweeb.org (Postfix) with ESMTPSA id BBBC67E328; Fri, 29 Jul 2022 00:57:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1659056241; bh=+/ba6ipUfKv0MdP3fWx/XqgD1d5VVVULCwFfZY4Kuq0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=IbWcB75gK2oBTihZ166aBdkxSmd+peM+cSEJAp8C2RYXoxxZVv33yWPo3lDRifz1p Fu1I6lBB+wemIyIZ8jPOaH3WwiS7/JQ34parHTSQVo0373IQScrv4MviPw8fQgmRYi 8x+VDfSM5Z4gaNDspAag81Sz2p2ua8IGjHiHTjU+UIST2dRoXDcKzFnpPxYay0BQdc 1TrUpAIlownRWRZBOT4lAeEr6yZFZhXISH7NTtaRvrpnc2oYqQcNY/iZlnXcILtCEy aUQd5//1bZSJnUU4/eJOOOjrT4SQeZ8qLH/2XTdTeJr9DqzpR3V6htLz1QdLTEPzts zEGXinYDxlNfQ== Message-ID: Date: Fri, 29 Jul 2022 07:57:14 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 00/18] New feature to handle atom URLs and broadcast Content-Language: en-US To: Muhammad Rizki Cc: GNU/Weeb Mailing List References: <20220729004507.1668-1-kiizuha@gnuweeb.org> From: Ammar Faizi In-Reply-To: <20220729004507.1668-1-kiizuha@gnuweeb.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: Rizki, On 7/29/22 7:44 AM, Muhammad Rizki wrote: > Morning sir, > > In this series I want to create a new feature to handle the atom URLs > and broadcast chats, such as add atom, add chat, del_atom and del_chat, > with this feature, we do not manual manage them again, just using > the bot commands and it will update in database. This series doesn't address the previous reviews. > ## Changelog > > v1 -> v2 > - Improve delete_broadcast() source code in scraper/db.py > - Fix typehints to int for chat_id param in scraper/db.py Only these two? > .gitignore | 4 + > daemon/atom_broadcast.sql | 25 +++++ > daemon/packages/client.py | 4 +- > daemon/packages/plugins/callbacks/del_atom.py | 31 +++++ > daemon/packages/plugins/callbacks/del_chat.py | 36 ++++++ > .../{admin.py => commands/debugger.py} | 0 > .../packages/plugins/commands/manage_atom.py | 50 +++++++++ > .../plugins/commands/manage_broadcast.py | 66 +++++++++++ > .../packages/plugins/{ => commands}/scrape.py | 0 > daemon/run.py | 16 +-- > daemon/scraper/bot.py | 22 +--- > daemon/scraper/db.py | 106 +++++++++++++++++- > daemon/scraper/utils.py | 45 ++++++++ > 13 files changed, 379 insertions(+), 26 deletions(-) > create mode 100644 daemon/atom_broadcast.sql > create mode 100644 daemon/packages/plugins/callbacks/del_atom.py > create mode 100644 daemon/packages/plugins/callbacks/del_chat.py > rename daemon/packages/plugins/{admin.py => commands/debugger.py} (100%) > create mode 100644 daemon/packages/plugins/commands/manage_atom.py > create mode 100644 daemon/packages/plugins/commands/manage_broadcast.py > rename daemon/packages/plugins/{ => commands}/scrape.py (100%) Just by reading the diffstat, I am not going to take your patches. At first sight this is still wrong, you still even have: daemon/atom_broadcast.sql while the previous review asked not to create a new database. Please address those first before sending a new revision, I don't want to see the same mistake in v3. Understand? -- Ammar Faizi