From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gnuweeb.org (Postfix) with ESMTPS id 685EE830DD for ; Thu, 16 Feb 2023 17:34:37 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QNP1v3xm; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676568876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EgF7DOl7V8ylK16O4PCdIIl9XiM5kM8q4lVhSqxVNYw=; b=QNP1v3xmT/PvPUUudQ9YJr9yX0a1j0sLJ7qsHzZFsTyBcSxQ3GSG9CsGZUjFenkyk9ujTj q2uypdfP4R3ifWjpVgG18ySAiVzi415/yq+qdJamoHn1T98OHHdjYgJVrRDc6ZAMQ6NyNy rGpbaLNJm1dTTTTtVc1E7LX3qDH3W4I= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-631-CtMGALBPNmOLVMTWkN8zxQ-1; Thu, 16 Feb 2023 12:34:34 -0500 X-MC-Unique: CtMGALBPNmOLVMTWkN8zxQ-1 Received: by mail-qv1-f70.google.com with SMTP id w2-20020a0cc702000000b0055c8ef137ddso1500045qvi.0 for ; Thu, 16 Feb 2023 09:34:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EgF7DOl7V8ylK16O4PCdIIl9XiM5kM8q4lVhSqxVNYw=; b=rlEKD4zPF7BuC9TEZCymQvYoPGfGrokwlzfivuoUiGopjgXdAh9HAnXSLA9R8FgS64 l2MB1r+R2FqnCzdmcmZvcjSbKcO1WSh0htpzXdlYd+UZpRwDrdVj030mRXAL+/4USCoL uCSjC2A0YxZcxod3Mcl+OGBsenn8zMtMVor6scuDHs2/Hf8ZVw06kiosfUNIIEFEmVnN 0Wzomvh6wOKNB/Xyie0C8ASCs774Lz65nim/ORe3y6vqDnoz1wwPkZQsiRwYZDuxoeOB 0h/zIiG0iIe0/vwiqXbXhL6GHFXl20FQMMH0hr1216TPqx4/+3yRHACBL9uzMw2g7csV USiA== X-Gm-Message-State: AO0yUKU2OLxj8WHVcvGTn/ewEeBK7HL2Hitzit33gmF+987q/veHyet4 uQVociYbYY03usw3AnIkh3F/eoHaFQWdF+zg0oT2V2hYUoavHLfa4x2mmlmgh6gaN4Luoxu4H5p 1RiTHTEb0LXUkCuQ= X-Received: by 2002:a05:622a:1897:b0:3b8:6d5a:3457 with SMTP id v23-20020a05622a189700b003b86d5a3457mr12358592qtc.6.1676568874294; Thu, 16 Feb 2023 09:34:34 -0800 (PST) X-Google-Smtp-Source: AK7set8hjUW5nlxcsnRidy2m+rttCluDyrsDLMX7f5LMdxWpu+WvYhj9oHGJQ3/UtdXDCFBK+iFwkQ== X-Received: by 2002:a05:622a:1897:b0:3b8:6d5a:3457 with SMTP id v23-20020a05622a189700b003b86d5a3457mr12358559qtc.6.1676568874027; Thu, 16 Feb 2023 09:34:34 -0800 (PST) Received: from gerbillo.redhat.com (146-241-121-8.dyn.eolo.it. [146.241.121.8]) by smtp.gmail.com with ESMTPSA id k1-20020ac80201000000b003b0766cd169sm1625330qtg.2.2023.02.16.09.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 09:34:33 -0800 (PST) Message-ID: Subject: Re: [ammarfaizi2-block:netdev/net-next/master 27/39] drivers/net/ethernet/sfc/efx_devlink.c:185:58: error: expected ')' before 'build_id' From: Paolo Abeni To: Alejandro Lucero Cc: oe-kbuild-all@lists.linux.dev, Ammar Faizi , GNU/Weeb Mailing List , Jiri Pirko , kernel test robot Date: Thu, 16 Feb 2023 18:34:30 +0100 In-Reply-To: <202302170047.EjCPizu3-lkp@intel.com> References: <202302170047.EjCPizu3-lkp@intel.com> User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Fri, 2023-02-17 at 00:12 +0800, kernel test robot wrote: > If you fix the issue, kindly add following tag where applicable > > Reported-by: kernel test robot > > Link: https://lore.kernel.org/oe-kbuild-all/202302170047.EjCPizu3-lkp@i= ntel.com/ >=20 > All errors (new ones prefixed by >>): >=20 > drivers/net/ethernet/sfc/efx_devlink.c: In function 'efx_devlink_info_= running_v2': > > > drivers/net/ethernet/sfc/efx_devlink.c:185:58: error: expected ')' be= fore 'build_id' > 185 | memset(&build_date, 0, sizeof(build_date) > | ~ ^ > | ) > 186 | #endif > 187 | build_id =3D MCDI_DWORD(outbuf, GET_VERSION_V2= _OUT_SUCFW_CHIP_ID); > | ~~~~~~~~ =20 > > > drivers/net/ethernet/sfc/efx_devlink.c:197:55: error: expected ';' be= fore '}' token > 197 | buf); > | ^ > | ; > 198 | } > | ~ =20 Alejandro, the bottom line is that your series need a follow-up as it breaks the build when CONFIG_RTC_LIB is not defined. I missed that at code review time. Could you please sent a fix (for net-next?) Thanks! Paolo