Re: [PATCH v1 03/13] refactor(telegram)!: Ensure the Telegram bot has been started

[Muhammad Rizki <kiizuha@gnuweeb.org>]

On 04/01/2023 05.27, Alviro Iskandar Setiawan wrote:
> On Wed, Jan 4, 2023 at 5:11 AM Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote:
>> On 1/3/23 7:17 PM, Muhammad Rizki wrote:
>>> No, we should use this method rather than `client.run()`. Why? because
>>> at the previous commit, we use `client.run()` after the `bot.run()`
>>> which is the `bot` here is running first before the Telegram bot is
>>> started/connect to the Telegram MTProto API, previous commit:
>>>
>>>        sched.start()
>>>
>>>        bot.run()       <- we listen for new emails, if error may
>>>                        happen, the listener will send the log file
>>>                        which is require to interact with the Telegram
>>>                        API.
>>>
>>>        client.run()    <- The client is late to start/connect to the
>>>                        Telegram API.
>>
>> What does this call ordering have to do with 'idle()'?
> 
> because the subsequent code calls client.stop(), what if you don't
> call client.stop()? but
> 
>      bot.run() # internally calls sched.start()

How about I do the refactoring again like this?

	async def run(self): 	# this is Bot() class
		client.start()
		
		self.runner = self.sched.add_job(
			func=self.__run,
			misfire_grace_time=None,
			max_instances=1
		)

		self.sched.start()
		idle()
		client.stop()

So, in the main file just call it `bot.run()`. What do you think?