From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kiizuha@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from [192.168.1.5] (unknown [175.158.50.88])
	by gnuweeb.org (Postfix) with ESMTPSA id A813D7FEA1;
	Thu, 19 Jan 2023 12:49:48 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1674132589;
	bh=8WhMCyZHlGYHcQzOVkwxdtz79qq3Ojg3sH33foSPZCw=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=WTqlffdoTC8ZgbuyHXMMc+2iXT1/raprHTuCKy+KFEHJeClQjLk/urGMLRQXPmViP
	 iDfIgxmMgIqzVzZ5Ki/8Zl/dwHIILPU9F+WtnrIIiKXL/aHnjse9tkefPBLobq8CwC
	 DMP0YlWq7Ps57SJqL7BSgW2+ncICeyy1TJUuJDXNK1JD5Mbx+1NbetqwmSL38jtJ5e
	 iqWQ4vCNiHZRfbFjvPfosL6kp1xtIoVzhpeAiAFXzqPMk3KUmM6I9twQW+OrIOhBPR
	 AqOTJ2D6+oodwUoSSlliZhUcsOl3/w7XXi4fMpZJLvAs/Wso03By+5y/nz42k7euLr
	 wb1sykLHSYB1g==
Message-ID: <f56e580f-347b-a24d-459e-6ab854723305@gnuweeb.org>
Date: Thu, 19 Jan 2023 19:49:43 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v2 00/17] Everything about logger changes and some fixes
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
 GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <20230118175356.1853-1-kiizuha@gnuweeb.org>
 <Y8jpJbXFkYcQaDG/@biznet-home.integral.gnuweeb.org>
Content-Language: en-US
From: Muhammad Rizki <kiizuha@gnuweeb.org>
In-Reply-To: <Y8jpJbXFkYcQaDG/@biznet-home.integral.gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

On 19/01/2023 13.54, Ammar Faizi wrote:
> On Thu, Jan 19, 2023 at 12:53:39AM +0700, Muhammad Rizki wrote:
>> - Patch 7 is to fix the type annotations for the Telegram's decorator.
> 
> You use 'typing_extensions' extension in patch #7.
> 
>> - Patch 16 is to move requirements.txt to the daemon and update deps.
> 
> But you add 'typing_extensions' in patch #16. This honestly, doesn't
> make sense from the test standpoint. You should add 'typing_extensions'
> to the requirement list first, then use it later. Each patch, when
> applied, should not leave a breakage in the middle.
> 
> To save time and internet bandwith, I just reordered it myself because
> it's simple enough for me to fix.
> 

Ah yes my bad, thanks anyway!