Re: [PATCH liburing v1 1/7] liburing.h: Export `__io_uring_flush_sq()` function

[Dylan Yudaken <dylany@meta.com>]

On Thu, 2022-11-24 at 15:00 +0700, Ammar Faizi wrote:
> From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
> 
> clang says:
> 
>   queue.c:204:10: error: no previous prototype for function \
>   '__io_uring_flush_sq' [-Werror,-Wmissing-prototypes] \
>   unsigned __io_uring_flush_sq(struct io_uring *ring)
>            ^
>   queue.c:204:1: note: declare 'static' if the function is not
> intended \
>   to be used outside of this translation unit \
>   unsigned __io_uring_flush_sq(struct io_uring *ring)
> 
> This function is used by test/iopoll.c, therefore, it can't be
> static.
> Export it.
> 
> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
> ---
>  src/include/liburing.h | 1 +
>  src/liburing.map       | 5 +++++
>  2 files changed, 6 insertions(+)
> 

I think changing the tests to use the public API is probably better
than exporting this function. I don't believe it has much general use?

Dylan