From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by gnuweeb.org (Postfix) with ESMTPS id 62E50804D1 for ; Thu, 20 Oct 2022 12:52:11 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=kernel-dk.20210112.gappssmtp.com header.i=@kernel-dk.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=UjO/JDY1; dkim-atps=neutral Received: by mail-pj1-f45.google.com with SMTP id t12-20020a17090a3b4c00b0020b04251529so2949238pjf.5 for ; Thu, 20 Oct 2022 05:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OL486cRIa/yjkXsURsjAZu0Hh8MyUBVelkMnNnPhT6Q=; b=UjO/JDY1FIN5uts78LmRtIxR84g/4ss1SSTNaZylujSbG5V55TZhRTxp/Y5CvoHRXi n45pW4nC1TF2MT1pEeT8o2QqgZZJEx3hffcAuL6ErDIwxQaf6wSburuNiwz/4mwbVKkV agaOyw9nsc7Uh63XMoE+jZpaOVr9HqJPHyRrYyWgjeQKf/+4Rx4MX42h7WrQykoqTNs1 c551lnqpZVbHB9TGOqThzP6sqo/pKBZZRgBh0GTa6kFLrmGViOOD3FT8UUwLpou2BQBC LdpFS0GTtgsQRCh2t///xr4ohKu2GJZRLddnc3Per+ML3Yh3gfVeFcKRLqPdcpjqwClH 9OEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OL486cRIa/yjkXsURsjAZu0Hh8MyUBVelkMnNnPhT6Q=; b=k09OxtLFUpsVkc87ns04cPEmHXjjaUXZ8pkgbMy/eWKHGW8DttRHv+2krd8ppfPCkv WdYAEYJ5aDd8YqIIuTpZkOH/6EXAUG8aumrFb6UZJuC0LCihqVIZpEp+aEnRgjHQxoD0 JkzlzjNOMxKthCAx8zoRp0vEzhsCVLQiu9tdI2InjvFQFiuYJm/7Qo0pwrrGw4cmSW/g 0Bq/i/lCqlE0l9qQ6r21mbE2eR+WDpb2fRsKG2zPR5rWqnSlJ4Yqrv1pLXtDfA6OIlVG HYWBpTyOMhkrA0KAZ/QMUXod+9ZtGAaPgNVC9AtxRkRhqvynb7PXlDeInkzQQ6SogQVe 0lnQ== X-Gm-Message-State: ACrzQf0lXRKje+FN+fzciu70uKSupB5glSB5eHxOkz6CP3pUMgsIImSv lg4pOSfYI91hfSIveQYVv1ylSQ== X-Google-Smtp-Source: AMsMyM60cDyvyOthu9kKpiIQifR9anhrqnoXVAMxGCKjYj8tunVESySU5eFBeH8DDzWI/qazI3MQ7g== X-Received: by 2002:a17:902:ce12:b0:17a:3e76:8568 with SMTP id k18-20020a170902ce1200b0017a3e768568mr13922858plg.11.1666270330759; Thu, 20 Oct 2022 05:52:10 -0700 (PDT) Received: from [192.168.4.201] (cpe-72-132-29-68.dc.res.rr.com. [72.132.29.68]) by smtp.gmail.com with ESMTPSA id b6-20020a170902650600b00186617af88fsm1560427plk.174.2022.10.20.05.52.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Oct 2022 05:52:10 -0700 (PDT) Message-ID: Date: Thu, 20 Oct 2022 05:52:08 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH liburing v1 1/3] liburing: Clean up `-Wshorten-64-to-32` warnings from clang Content-Language: en-US To: Ammar Faizi , Dylan Yudaken Cc: Pavel Begunkov , GNU/Weeb Mailing List , io-uring Mailing List , Facebook Kernel Team , Dylan Yudaken References: <20221020114814.63133-1-ammar.faizi@intel.com> <20221020114814.63133-2-ammar.faizi@intel.com> <0e72af49-9e6c-2cc2-c53c-3966b20517cf@gnuweeb.org> From: Jens Axboe In-Reply-To: <0e72af49-9e6c-2cc2-c53c-3966b20517cf@gnuweeb.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit List-Id: On 10/20/22 5:12 AM, Ammar Faizi wrote: > On 10/20/22 6:52 PM, Ammar Faizi wrote: >> From: Dylan Yudaken >> >> liburing has a couple of int shortening issues found by clang. Clean >> them all. This cleanup is particularly useful for build systems that >> include these files and run with that error enabled. >> >> Link:https://lore.kernel.org/io-uring/20221019145042.446477-1-dylany@meta.com >> Signed-off-by: Dylan Yudaken >> Co-authored-by: Ammar Faizi >> Signed-off-by: Ammar Faizi > > BTW, before it's too late. I think we should be consistent on the cast > style: > >    (type) a > > or > >    (type)a > > What do you think? I tend to prefer (type) a, but sometimes if you have multiple casts or the lines become too long, I'll do (type)a. I don't think it's super important in terms of style, as it isn't that prevalent. -- Jens Axboe