From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kiizuha@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS,
	URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no
	version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1741226566;
	bh=o3qn0Lx8woW0O6jWor8ZU1lD78CRSdOo/I6Myi7RNqg=;
	h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:
	 Content-Language:From:In-Reply-To:Content-Type:
	 Content-Transfer-Encoding:Message-ID:Date:From:Reply-To:Subject:To:
	 Cc:In-Reply-To:References:Resent-Date:Resent-From:Resent-To:
	 Resent-Cc:User-Agent:Content-Type:Content-Transfer-Encoding;
	b=UtORz0RGBYUgnY24QMWxq6ZhPBa3PWNVsKFXlS3w8CnakRqcIVDhF9WUEIA0V+jBw
	 z8DfSDa5aAzEcGu7ty0EHuZOqhjkR2u0CqMKt1uPnZyvRkwKazBhs1kYFywin5nO2T
	 S7w8Fr3oDq7QIhUe+MwjDhoKVr3dDeYoFZTK3mAHVMVJv7XkVE33xahIYU+UWoTfpw
	 NfLAlWQM4oYvNRGvZien7pnNrpY70wTC1/N6bY3A2vBTdRLzBlmPXRY4tcH0zyd0Dk
	 aEvCcPFC9rlrWFr/wFAsHUshJpHvlPjNiKtYR/7JBuQr7SX46KdxYyu/z5ZHS+BkGt
	 cXznMr58RRduw==
Received: from [172.16.59.176] (unknown [203.217.140.198])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 1E82220B4838;
	Thu,  6 Mar 2025 02:02:45 +0000 (UTC)
Message-ID: <fa396a89-7ab7-42ec-9285-68777f2c6398@gnuweeb.org>
Date: Thu, 6 Mar 2025 09:02:44 +0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 00/17] Profile Page, SEO, Fixed API structure, Docs
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
 GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <20250305144018.267-1-kiizuha@gnuweeb.org>
 <Z8iBy7CI8mFDe/0i@biznet-home.integral.gnuweeb.org>
Content-Language: en-US
From: Muhammad Rizki <kiizuha@gnuweeb.org>
In-Reply-To: <Z8iBy7CI8mFDe/0i@biznet-home.integral.gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

On 05/03/2025 23:54, Ammar Faizi wrote:
> On Wed, Mar 05, 2025 at 09:39:59PM +0700, Muhammad Rizki wrote:
>> This series of patches was planned only to update profile page feature,
>> since there is a change in the API structure, I also fixed
>> the API response type to prevent breaking change.
>>
>> To prevent more breaking change on production site in the future,
>> sir Ammar has made a staging API for development stage,
>> since there is a staging API version, I added an environment variable
>> `PUBLIC_BASE_URL` for each environment (development or production).
>> You should set `PUBLIC_BASE_URL` environment in your own server,
>> there is an example file for development and production environment
>> in this patch, please see `.env.development.example` and
>> `.env.production.example` in root directory.
> 
> So, in my testing, the assets loading process is still broken. I had to
> reapply this patch manually to get it working:
> 
> diff --git a/svelte.config.js b/svelte.config.js
> index 5a6890a..40dc905 100644
> --- a/svelte.config.js
> +++ b/svelte.config.js
> @@ -5,6 +5,7 @@ import { vitePreprocess } from "@sveltejs/vite-plugin-svelte";
>   const config = {
>     preprocess: vitePreprocess(),
>     kit: {
> +    paths: { relative: false },
>       adapter: adapter({
>         pages: "dist",
>         assets: "dist",
> 
> That's fine. Also, I found that the delete profile photo button does
> not work.
> 
> Please send follow up patches for these two problems:
> 
> 1) Use 'paths: { relative: false }' to make it work on nginx.

Oh, I forgot to add it.

> 
> 2) Fix the 'delete' button on photo profile.

Also, forgot this too.

> 
> Don't send a v2 revision, just two new patches. This series is good to
> be applied, just a bit incomplete...
> 

Make a new revision?