Re: [PATCH v1 11/11] feat(page): implement chat bubble message rendering

[Muhammad Rizki <kiizuha@gnuweeb.org>]

On 23/09/2023 10.15, Ammar Faizi wrote:
> On 2023/09/23 午前3:58, Muhammad Rizki wrote:
>> +      function getFixedRandomColor(name) {
>> +        const textColors = [
>> +          "text-red-400",      "text-yellow-400",
>> +          "text-blue-400",     "text-sky-400",
>> +          "text-purple-400",   "text-orange-400",
>> +          "text-amber-400",    "text-lime-400",
>> +          "text-green-400",    "text-emerald-400",
>> +          "text-teal-400",     "text-cyan-400",
>> +          "text-indigo-400",   "text-violet-400",
>> +          "text-fuchsia-400",  "text-pink-400",
>> +          "text-rose-400"
>> +        ];
>> +        const borderColors = [
>> +          "border-red-400",      "border-yellow-400",
>> +          "border-blue-400",     "border-sky-400",
>> +          "border-purple-400",   "border-orange-400",
>> +          "border-amber-400",    "border-lime-400",
>> +          "border-green-400",    "border-emerald-400",
>> +          "border-teal-400",     "border-cyan-400",
>> +          "border-indigo-400",   "border-violet-400",
>> +          "border-fuchsia-400",  "border-pink-400",
>> +          "border-rose-400"
>> +        ];
>> +
>> +        const hash = hashCode(name);
>> +        const range = textColors && textColors.length;
> 
> At a glance, I thought that @range was a boolean. But it's not.
> What does the "&&" operator do? Can't you just assign it this way?
> ```
>      const range = textColors.length;
> ```

Yes, it doesn't need to complicate the code with `&&`.

> @textColors is always defined. I don't think it needs that
> stupid "&&" op game either. What's the purpose behind it?
> 
>> +        const indexColor = hash % range;
>> +
>> +        return [
>> +          textColors[(hashCode(name)) % range],
>> +          borderColors[(hashCode(name)) % range]
>> +        ];
>> +      }
> 

It will be fixed in the next series. Thanks!