public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Begunkov <asml.silence@gmail.com>
To: Joanne Koong <joannelkoong@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	axboe@kernel.dk, io-uring@vger.kernel.org,
	csander@purestorage.com, krisman@suse.de, bernd@bsbernd.com,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v1 03/11] io_uring/kbuf: add support for kernel-managed buffer rings
Date: Fri, 27 Feb 2026 20:05:48 +0000	[thread overview]
Message-ID: <000f7db7-5546-4680-bef2-84ce740ad8fd@gmail.com> (raw)
In-Reply-To: <CAJnrk1a1FAARebZ0Aqw18zxtOy8WTMb2UfcAK6jQaigXiZbTfQ@mail.gmail.com>

On 2/24/26 22:19, Joanne Koong wrote:
> On Mon, Feb 23, 2026 at 12:00 PM Pavel Begunkov <asml.silence@gmail.com> wrote:
>>
>> On 2/21/26 02:14, Joanne Koong wrote:
>>> On Fri, Feb 20, 2026 at 4:53 AM Pavel Begunkov <asml.silence@gmail.com> wrote:
>> ...
>>>> So I'm asking whether you expect that a server or other user space
>>>> program should be able to issue a READ_OP_RECV, READ_OP_READ or any
>>>> other similar request, which would consume buffers/entries from the
>>>> km ring without any fuse kernel code involved? Do you have some
>>>> use case for that in mind?
>>>
>>> Thanks for clarifying your question. Yes, this would be a useful
>>> optimization in the future for fuse servers with certain workload
>>> characteristics (eg network-backed servers with high concurrency and
>>> unpredictable latencies). I don't think the concept of kmbufrings is
>>> exclusively fuse-specific though (for example, Christoph's use case
>>> being a recent instance);
>>
>> Sorry, I don't see relevance b/w km rings and what Christoph wants.
>> I explained why in some sub-thread, but maybe someone can tell
>> what I'm missing.
>>
>>> I think other subsystems/users that'll use
>>> kmbuf rings would also generically find it useful to have the option
>>> of READ_OP_RECV/READ_OP_READ operating directly on the ring.
>>
>> Yep, it could be, potentially, it's just the patchset doesn't plumb
>> it to other requests and uses it within fuse. It's just cases like
> 
> This patchset just represents the most basic foundation. The
> optimization patches (eg incremental buffer consumption, plumbing it
> to other io-uring requests, etc) were to be follow-up patchsets that
> would be on top of this.

Got it. Any understanding how the work flow would look like if used
with non-cmd io_uring requests? Is there some particular use case
you have in mind for fuse servers?

>> that always make me wonder, here it was why what is basically an
>> internal kernel fuse API is exposed as an io_uring uapi. Maybe there
> 
> It's not really an internal kernel fuse API. There's nothing
> fuse-specific about it - the infrastructure that's added is the
> infrastructure for a generic buffer ring.
> 
> The memory that backs the buffers for the buf ring needs to be
> io-uring specific. io-uring already has all the infrastructure for
> buffer rings. So I'm not really fully understanding why it's better in
> this case to just have the fuse kernel code re-implement all the logic
> for a buffer ring and go through these layers of indirection to use
> registered buffers, instead of just leveraging what's already in
> io-uring.

It's simple. If user space (i.e. fuse server) knows the buffer
address prior to request submission, then it should either use plain
user addresses or registered buffers. Introducing a major io_uring
uapi extension that does the same thing as registered buffers but
for regions, as you suggested, is not the right approach.

...
>> It's up to the user (i.e. fuse server) to either use OP_READ/etc. using
>> user addresses that you have in your design from mmap()ing regions, or
>> registering it and using OP_READ_FIXED.
> 
> Yes but I don't think this solves the concern of userspace being able
> to unregister the memory region at any time (eg while not doing
> io-uring requests) while the kernel still points to those addresses
> for the backing buffers of the bufring, since there's no callback that

If you allow normal requests to use it, a fuse callback on region
unregistration wouldn't help anyway.

> gets triggered in the subsystem when a memory region is unregistered,
> which means there will need to be extra per I/O overhead for having to
> ensure the memory region is still valid. Though since there's no uapi
> for unregistering a memory region this is not a concern, unless this
> is planned to be added in the future.

You can assume it's not going to be unregistered.

-- 
Pavel Begunkov


  reply	other threads:[~2026-02-27 20:05 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10  0:28 [PATCH v1 00/11] io_uring: add kernel-managed buffer rings Joanne Koong
2026-02-10  0:28 ` [PATCH v1 01/11] io_uring/kbuf: refactor io_register_pbuf_ring() logic into generic helpers Joanne Koong
2026-02-10  0:28 ` [PATCH v1 02/11] io_uring/kbuf: rename io_unregister_pbuf_ring() to io_unregister_buf_ring() Joanne Koong
2026-02-10  0:28 ` [PATCH v1 03/11] io_uring/kbuf: add support for kernel-managed buffer rings Joanne Koong
2026-02-10 16:34   ` Pavel Begunkov
2026-02-10 19:39     ` Joanne Koong
2026-02-11 12:01       ` Pavel Begunkov
2026-02-11 22:06         ` Joanne Koong
2026-02-12 10:07           ` Christoph Hellwig
2026-02-12 10:52             ` Pavel Begunkov
2026-02-12 17:29               ` Joanne Koong
2026-02-13  7:27                 ` Christoph Hellwig
2026-02-13 15:31                   ` Pavel Begunkov
2026-02-13 15:48                     ` Pavel Begunkov
2026-02-13 19:09                     ` Joanne Koong
2026-02-13 19:30                       ` Bernd Schubert
2026-02-13 19:38                         ` Joanne Koong
2026-02-17  5:36                       ` Christoph Hellwig
2026-02-13 19:14                   ` Joanne Koong
2026-02-17  5:38                     ` Christoph Hellwig
2026-02-18  9:51                       ` Pavel Begunkov
2026-02-13 16:27                 ` Pavel Begunkov
2026-02-13  7:21               ` Christoph Hellwig
2026-02-13 13:18                 ` Pavel Begunkov
2026-02-13 15:26           ` Pavel Begunkov
2026-02-27  1:12           ` Joanne Koong
2026-02-27 20:48             ` Pavel Begunkov
2026-02-11 15:45     ` Christoph Hellwig
2026-02-12 10:44       ` Pavel Begunkov
2026-02-13  7:18         ` Christoph Hellwig
2026-02-13 12:41           ` Pavel Begunkov
2026-02-13 22:04             ` Joanne Koong
2026-02-18 12:36               ` Pavel Begunkov
2026-02-18 21:43                 ` Joanne Koong
2026-02-20 12:53                   ` Pavel Begunkov
2026-02-21  2:14                     ` Joanne Koong
2026-02-23 20:00                       ` Pavel Begunkov
2026-02-24 22:19                         ` Joanne Koong
2026-02-27 20:05                           ` Pavel Begunkov [this message]
2026-02-10  0:28 ` [PATCH v1 04/11] io_uring/kbuf: add mmap " Joanne Koong
2026-02-10  1:02   ` Jens Axboe
2026-02-10  0:28 ` [PATCH v1 05/11] io_uring/kbuf: support kernel-managed buffer rings in buffer selection Joanne Koong
2026-02-10  0:28 ` [PATCH v1 06/11] io_uring/kbuf: add buffer ring pinning/unpinning Joanne Koong
2026-02-10  1:07   ` Jens Axboe
2026-02-10 17:57     ` Caleb Sander Mateos
2026-02-10 18:00       ` Jens Axboe
2026-02-10  0:28 ` [PATCH v1 07/11] io_uring/kbuf: add recycling for kernel managed buffer rings Joanne Koong
2026-02-10  0:52   ` Jens Axboe
2026-02-10  0:28 ` [PATCH v1 08/11] io_uring/kbuf: add io_uring_is_kmbuf_ring() Joanne Koong
2026-02-10  0:28 ` [PATCH v1 09/11] io_uring/kbuf: export io_ring_buffer_select() Joanne Koong
2026-02-10  0:28 ` [PATCH v1 10/11] io_uring/kbuf: return buffer id in buffer selection Joanne Koong
2026-02-10  0:53   ` Jens Axboe
2026-02-10 22:36     ` Joanne Koong
2026-02-10  0:28 ` [PATCH v1 11/11] io_uring/cmd: set selected buffer index in __io_uring_cmd_done() Joanne Koong
2026-02-10  0:55 ` [PATCH v1 00/11] io_uring: add kernel-managed buffer rings Jens Axboe
2026-02-10 22:45   ` Joanne Koong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=000f7db7-5546-4680-bef2-84ce740ad8fd@gmail.com \
    --to=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=bernd@bsbernd.com \
    --cc=csander@purestorage.com \
    --cc=hch@infradead.org \
    --cc=io-uring@vger.kernel.org \
    --cc=joannelkoong@gmail.com \
    --cc=krisman@suse.de \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox