public inbox for io-uring@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: io-uring Mailing List <io-uring@vger.kernel.org>,
	GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH liburing] src/Makefile: Fix missing bpf_filter.h installation
Date: Fri, 13 Feb 2026 14:10:47 -0700	[thread overview]
Message-ID: <00bc96d8-c304-412c-b176-1b30ff0847af@kernel.dk> (raw)
In-Reply-To: <177101682427.298850.12069195780298295812.b4-ty@kernel.dk>

On 2/13/26 2:07 PM, Jens Axboe wrote:
> 
> On Sat, 14 Feb 2026 04:05:48 +0700, Ammar Faizi wrote:
>> After a "make install" command, liburing.h fails to compile because
>> bpf_filter.h is not copied to the destination include directory:
>>
>>     In file included from .github/workflows/test_build.c:1:
>>     /usr/include/liburing.h:21:10: fatal error: liburing/io_uring/bpf_filter.h: No such file or directory
>>     21 | #include "liburing/io_uring/bpf_filter.h"
>>         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>     compilation terminated.
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/1] src/Makefile: Fix missing bpf_filter.h installation
>       commit: 364a7b561fa13cffdd7771978dc5509ec4d9d7f9

Thanks, I missed that!

BTW, for the future, for:

Fixes: 46b5c4d66232dcadd0f46c875e6fabce3b3dea85 ("src/include/liburing.h: add bpf_filter.h header")

shorten the sha to 12 chars, we don't need the full sha.

For your ~/.gitconfig:

[core]
	abbrev = 12
[pretty]
	fixes = Fixes: %h (\"%s\")
[alias]
	fixes = log -1 --format=fixes

and then you can just do:

axboe@m2max ~/gi/liburing (master)> git fixes 46b5c4d66232dcadd0f46c875e6fabce3b3dea85
Fixes: 46b5c4d66232 ("src/include/liburing.h: add bpf_filter.h header")

and it gives you the right format.

-- 
Jens Axboe

  reply	other threads:[~2026-02-13 21:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13 21:05 [PATCH liburing] src/Makefile: Fix missing bpf_filter.h installation Ammar Faizi
2026-02-13 21:07 ` Jens Axboe
2026-02-13 21:10   ` Jens Axboe [this message]
2026-02-13 21:18     ` Ammar Faizi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00bc96d8-c304-412c-b176-1b30ff0847af@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=ammarfaizi2@gnuweeb.org \
    --cc=gwml@vger.gnuweeb.org \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox