From: Jens Axboe <[email protected]>
To: Stefan Metzmacher <[email protected]>,
Pavel Begunkov <[email protected]>,
[email protected]
Subject: Re: IORING_SETUP_ATTACH_WQ (was Re: [PATCH 1/3] io_uring: fix invalid ctx->sq_thread_idle)
Date: Thu, 11 Mar 2021 08:28:36 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 3/11/21 5:02 AM, Stefan Metzmacher wrote:
> Or we completely ignore IORING_SETUP_ATTACH_WQ (execpt the error
> cases).
>
> Then we can implement a new IORING_SETUP_ATTACH_SQ with new semantics,
> that the existing sq_thread will be used as it and both sides now what
> it means to them. We also add a new
> IORING_REGISTER_RESTRICTIONS/IORING_RESTRICTION_ALLOW_SQ_ATTACHMENTS
> which prepares the first io_ring_ctx to allow others to attach.
>
> Would that make sense?
I think we should retain ATTACH_WQ semantics with SQPOLL for the cases
that are possible. That would not exclude doing a more specific
ATTACH_SQ for the new case. And maybe those two cases can then be folded
down the line.
--
Jens Axboe
next prev parent reply other threads:[~2021-03-11 15:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 13:13 [PATCH 5.12 0/3] sqpoll fixes/cleanups Pavel Begunkov
2021-03-10 13:13 ` [PATCH 1/3] io_uring: fix invalid ctx->sq_thread_idle Pavel Begunkov
2021-03-10 13:56 ` Stefan Metzmacher
2021-03-11 10:49 ` Stefan Metzmacher
2021-03-11 11:18 ` Pavel Begunkov
2021-03-11 11:46 ` IORING_SETUP_ATTACH_WQ (was Re: [PATCH 1/3] io_uring: fix invalid ctx->sq_thread_idle) Stefan Metzmacher
2021-03-11 12:02 ` Stefan Metzmacher
2021-03-11 15:28 ` Jens Axboe [this message]
2021-03-11 12:27 ` Pavel Begunkov
2021-03-11 12:44 ` Stefan Metzmacher
2021-03-11 15:30 ` Jens Axboe
2021-03-11 15:38 ` Jens Axboe
2021-03-11 15:54 ` Stefan Metzmacher
2021-03-11 15:27 ` Jens Axboe
2021-03-10 13:13 ` [PATCH 2/3] io_uring: remove indirect ctx into sqo injection Pavel Begunkov
2021-03-10 13:13 ` [PATCH 3/3] io_uring: simplify io_sqd_update_thread_idle() Pavel Begunkov
2021-03-10 14:38 ` [PATCH 5.12 0/3] sqpoll fixes/cleanups Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox