* [PATCH liburing 0/3] sendzc test improvements
@ 2023-03-01 16:10 Pavel Begunkov
2023-03-01 16:10 ` [PATCH liburing 1/3] examples/send-zc: add affinity / CPU pinning Pavel Begunkov
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Pavel Begunkov @ 2023-03-01 16:10 UTC (permalink / raw)
To: io-uring; +Cc: Jens Axboe, asml.silence
Add affinity, multithreading and the server
Pavel Begunkov (3):
examples/send-zc: add affinity / CPU pinning
examples/send-zc: add multithreading
examples/send-zc: add the receive part
examples/Makefile | 3 +
examples/send-zerocopy.c | 277 ++++++++++++++++++++++++++++++++++-----
2 files changed, 249 insertions(+), 31 deletions(-)
--
2.39.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH liburing 1/3] examples/send-zc: add affinity / CPU pinning
2023-03-01 16:10 [PATCH liburing 0/3] sendzc test improvements Pavel Begunkov
@ 2023-03-01 16:10 ` Pavel Begunkov
2023-03-01 16:10 ` [PATCH liburing 2/3] examples/send-zc: add multithreading Pavel Begunkov
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Pavel Begunkov @ 2023-03-01 16:10 UTC (permalink / raw)
To: io-uring; +Cc: Jens Axboe, asml.silence
Pass '-C <cpu_num>' to pin threads and io-wq to the specified CPU.
Signed-off-by: Pavel Begunkov <[email protected]>
---
examples/send-zerocopy.c | 37 ++++++++++++++++++++++++++++++++++++-
1 file changed, 36 insertions(+), 1 deletion(-)
diff --git a/examples/send-zerocopy.c b/examples/send-zerocopy.c
index c9b5506..a86106f 100644
--- a/examples/send-zerocopy.c
+++ b/examples/send-zerocopy.c
@@ -12,6 +12,7 @@
#include <stdarg.h>
#include <string.h>
+#include <sched.h>
#include <arpa/inet.h>
#include <linux/errqueue.h>
#include <linux/if_packet.h>
@@ -50,6 +51,7 @@ static int cfg_nr_reqs = 8;
static bool cfg_fixed_buf = 1;
static bool cfg_hugetlb = 0;
static bool cfg_defer_taskrun = 0;
+static int cfg_cpu = -1;
static int cfg_family = PF_UNSPEC;
static int cfg_payload_len;
@@ -79,6 +81,32 @@ static void t_error(int status, int errnum, const char *format, ...)
exit(status);
}
+static void set_cpu_affinity(void)
+{
+ cpu_set_t mask;
+
+ if (cfg_cpu == -1)
+ return;
+
+ CPU_ZERO(&mask);
+ CPU_SET(cfg_cpu, &mask);
+ if (sched_setaffinity(0, sizeof(mask), &mask))
+ t_error(1, errno, "unable to pin cpu\n");
+}
+
+static void set_iowq_affinity(struct io_uring *ring)
+{
+ cpu_set_t mask;
+ int ret;
+
+ if (cfg_cpu == -1)
+ return;
+
+ ret = io_uring_register_iowq_aff(ring, 1, &mask);
+ if (ret)
+ t_error(1, ret, "unabled to set io-wq affinity\n");
+}
+
static unsigned long gettimeofday_ms(void)
{
struct timeval tv;
@@ -172,6 +200,9 @@ static void do_tx(int domain, int type, int protocol)
if (ret)
t_error(1, ret, "io_uring: queue init");
+ set_cpu_affinity();
+ set_iowq_affinity(&ring);
+
if (cfg_fixed_files) {
ret = io_uring_register_files(&ring, &fd, 1);
if (ret < 0)
@@ -303,7 +334,7 @@ static void parse_opts(int argc, char **argv)
cfg_payload_len = max_payload_len;
- while ((c = getopt(argc, argv, "46D:p:s:t:n:z:b:l:d")) != -1) {
+ while ((c = getopt(argc, argv, "46D:p:s:t:n:z:b:l:dC:")) != -1) {
switch (c) {
case '4':
if (cfg_family != PF_UNSPEC)
@@ -344,6 +375,9 @@ static void parse_opts(int argc, char **argv)
case 'd':
cfg_defer_taskrun = 1;
break;
+ case 'C':
+ cfg_cpu = strtol(optarg, NULL, 0);
+ break;
}
}
@@ -363,6 +397,7 @@ int main(int argc, char **argv)
const char *cfg_test;
parse_opts(argc, argv);
+ set_cpu_affinity();
payload = payload_buf;
if (cfg_hugetlb) {
--
2.39.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH liburing 2/3] examples/send-zc: add multithreading
2023-03-01 16:10 [PATCH liburing 0/3] sendzc test improvements Pavel Begunkov
2023-03-01 16:10 ` [PATCH liburing 1/3] examples/send-zc: add affinity / CPU pinning Pavel Begunkov
@ 2023-03-01 16:10 ` Pavel Begunkov
2023-03-01 16:10 ` [PATCH liburing 3/3] examples/send-zc: add the receive part Pavel Begunkov
2023-03-01 20:00 ` [PATCH liburing 0/3] sendzc test improvements Jens Axboe
3 siblings, 0 replies; 6+ messages in thread
From: Pavel Begunkov @ 2023-03-01 16:10 UTC (permalink / raw)
To: io-uring; +Cc: Jens Axboe, asml.silence
'-T <nr_threads>' will create the specified number of threads to test in
parallel. Each thread will have its own connection.
Signed-off-by: Pavel Begunkov <[email protected]>
---
examples/Makefile | 3 +
examples/send-zerocopy.c | 116 ++++++++++++++++++++++++++-------------
2 files changed, 81 insertions(+), 38 deletions(-)
diff --git a/examples/Makefile b/examples/Makefile
index e561e05..20ac53c 100644
--- a/examples/Makefile
+++ b/examples/Makefile
@@ -10,6 +10,9 @@ ifneq ($(MAKECMDGOALS),clean)
include ../config-host.mak
endif
+LDFLAGS ?=
+override LDFLAGS += -L../src/ -luring -lpthread
+
example_srcs := \
io_uring-cp.c \
io_uring-test.c \
diff --git a/examples/send-zerocopy.c b/examples/send-zerocopy.c
index a86106f..c0549a1 100644
--- a/examples/send-zerocopy.c
+++ b/examples/send-zerocopy.c
@@ -11,6 +11,7 @@
#include <stdbool.h>
#include <stdarg.h>
#include <string.h>
+#include <pthread.h>
#include <sched.h>
#include <arpa/inet.h>
@@ -43,6 +44,16 @@
#define ZC_TAG 0xfffffffULL
#define MAX_SUBMIT_NR 512
+#define MAX_THREADS 100
+
+struct thread_data {
+ pthread_t thread;
+ void *ret;
+ int idx;
+ unsigned long long packets;
+ unsigned long long bytes;
+ struct sockaddr_storage dst_addr;
+};
static bool cfg_reg_ringfd = true;
static bool cfg_fixed_files = 1;
@@ -52,17 +63,21 @@ static bool cfg_fixed_buf = 1;
static bool cfg_hugetlb = 0;
static bool cfg_defer_taskrun = 0;
static int cfg_cpu = -1;
+static unsigned cfg_nr_threads = 1;
static int cfg_family = PF_UNSPEC;
+static int cfg_type = 0;
static int cfg_payload_len;
static int cfg_port = 8000;
static int cfg_runtime_ms = 4200;
static socklen_t cfg_alen;
-static struct sockaddr_storage cfg_dst_addr;
+static char *str_addr = NULL;
static char payload_buf[IP_MAXPACKET] __attribute__((aligned(4096)));
static char *payload;
+static struct thread_data threads[MAX_THREADS];
+static pthread_barrier_t barrier;
/*
* Implementation of error(3), prints an error message and exits.
@@ -126,12 +141,13 @@ static void setup_sockaddr(int domain, const char *str_addr,
{
struct sockaddr_in6 *addr6 = (void *) sockaddr;
struct sockaddr_in *addr4 = (void *) sockaddr;
+ int port = cfg_port;
switch (domain) {
case PF_INET:
memset(addr4, 0, sizeof(*addr4));
addr4->sin_family = AF_INET;
- addr4->sin_port = htons(cfg_port);
+ addr4->sin_port = htons(port);
if (str_addr &&
inet_pton(AF_INET, str_addr, &(addr4->sin_addr)) != 1)
t_error(1, 0, "ipv4 parse error: %s", str_addr);
@@ -139,7 +155,7 @@ static void setup_sockaddr(int domain, const char *str_addr,
case PF_INET6:
memset(addr6, 0, sizeof(*addr6));
addr6->sin6_family = AF_INET6;
- addr6->sin6_port = htons(cfg_port);
+ addr6->sin6_port = htons(port);
if (str_addr &&
inet_pton(AF_INET6, str_addr, &(addr6->sin6_addr)) != 1)
t_error(1, 0, "ipv6 parse error: %s", str_addr);
@@ -149,21 +165,6 @@ static void setup_sockaddr(int domain, const char *str_addr,
}
}
-static int do_setup_tx(int domain, int type, int protocol)
-{
- int fd;
-
- fd = socket(domain, type, protocol);
- if (fd == -1)
- t_error(1, errno, "socket t");
-
- do_setsockopt(fd, SOL_SOCKET, SO_SNDBUF, 1 << 21);
-
- if (connect(fd, (void *) &cfg_dst_addr, cfg_alen))
- t_error(1, errno, "connect");
- return fd;
-}
-
static inline struct io_uring_cqe *wait_cqe_fast(struct io_uring *ring)
{
struct io_uring_cqe *cqe;
@@ -179,11 +180,9 @@ static inline struct io_uring_cqe *wait_cqe_fast(struct io_uring *ring)
return cqe;
}
-static void do_tx(int domain, int type, int protocol)
+static void do_tx(struct thread_data *td, int domain, int type, int protocol)
{
const int notif_slack = 128;
- unsigned long packets = 0;
- unsigned long bytes = 0;
struct io_uring ring;
struct iovec iov;
uint64_t tstop;
@@ -194,7 +193,14 @@ static void do_tx(int domain, int type, int protocol)
if (cfg_defer_taskrun)
ring_flags |= IORING_SETUP_DEFER_TASKRUN;
- fd = do_setup_tx(domain, type, protocol);
+ fd = socket(domain, type, protocol);
+ if (fd == -1)
+ t_error(1, errno, "socket t");
+
+ do_setsockopt(fd, SOL_SOCKET, SO_SNDBUF, 1 << 21);
+
+ if (connect(fd, (void *)&td->dst_addr, cfg_alen))
+ t_error(1, errno, "connect, idx %i", td->idx);
ret = io_uring_queue_init(512, &ring, ring_flags);
if (ret)
@@ -221,6 +227,8 @@ static void do_tx(int domain, int type, int protocol)
if (ret)
t_error(1, ret, "io_uring: buffer registration");
+ pthread_barrier_wait(&barrier);
+
tstop = gettimeofday_ms() + cfg_runtime_ms;
do {
struct io_uring_sqe *sqe;
@@ -272,8 +280,8 @@ static void do_tx(int domain, int type, int protocol)
compl_cqes++;
if (cqe->res >= 0) {
- packets++;
- bytes += cqe->res;
+ td->packets++;
+ td->bytes += cqe->res;
} else if (cqe->res == -ECONNREFUSED || cqe->res == -EPIPE ||
cqe->res == -ECONNRESET) {
fprintf(stderr, "Connection failure");
@@ -290,11 +298,6 @@ out_fail:
if (close(fd))
t_error(1, errno, "close");
- fprintf(stderr, "tx=%lu (MB=%lu), tx/s=%lu (MB/s=%lu)\n",
- packets, bytes >> 20,
- packets / (cfg_runtime_ms / 1000),
- (bytes >> 20) / (cfg_runtime_ms / 1000));
-
while (compl_cqes) {
struct io_uring_cqe *cqe = wait_cqe_fast(&ring);
@@ -304,14 +307,16 @@ out_fail:
io_uring_queue_exit(&ring);
}
-static void do_test(int domain, int type, int protocol)
+
+static void *do_test(void *arg)
{
- int i;
+ struct thread_data *td = arg;
+ int protocol = 0;
- for (i = 0; i < IP_MAXPACKET; i++)
- payload[i] = 'a' + (i % 26);
+ setup_sockaddr(cfg_family, str_addr, &td->dst_addr);
- do_tx(domain, type, protocol);
+ do_tx(td, cfg_family, cfg_type, protocol);
+ pthread_exit(&td->ret);
}
static void usage(const char *filepath)
@@ -334,7 +339,7 @@ static void parse_opts(int argc, char **argv)
cfg_payload_len = max_payload_len;
- while ((c = getopt(argc, argv, "46D:p:s:t:n:z:b:l:dC:")) != -1) {
+ while ((c = getopt(argc, argv, "46D:p:s:t:n:z:b:l:dC:T:")) != -1) {
switch (c) {
case '4':
if (cfg_family != PF_UNSPEC)
@@ -378,6 +383,11 @@ static void parse_opts(int argc, char **argv)
case 'C':
cfg_cpu = strtol(optarg, NULL, 0);
break;
+ case 'T':
+ cfg_nr_threads = strtol(optarg, NULL, 0);
+ if (cfg_nr_threads > MAX_THREADS)
+ t_error(1, 0, "too many threads\n");
+ break;
}
}
@@ -386,7 +396,7 @@ static void parse_opts(int argc, char **argv)
if (cfg_payload_len > max_payload_len)
t_error(1, 0, "-s: payload exceeds max (%d)", max_payload_len);
- setup_sockaddr(cfg_family, daddr, &cfg_dst_addr);
+ str_addr = daddr;
if (optind != argc - 1)
usage(argv[0]);
@@ -394,7 +404,11 @@ static void parse_opts(int argc, char **argv)
int main(int argc, char **argv)
{
+ unsigned long long packets = 0, bytes = 0;
+ struct thread_data *td;
const char *cfg_test;
+ void *res;
+ int i;
parse_opts(argc, argv);
set_cpu_affinity();
@@ -412,11 +426,37 @@ int main(int argc, char **argv)
cfg_test = argv[argc - 1];
if (!strcmp(cfg_test, "tcp"))
- do_test(cfg_family, SOCK_STREAM, 0);
+ cfg_type = SOCK_STREAM;
else if (!strcmp(cfg_test, "udp"))
- do_test(cfg_family, SOCK_DGRAM, 0);
+ cfg_type = SOCK_DGRAM;
else
t_error(1, 0, "unknown cfg_test %s", cfg_test);
+ pthread_barrier_init(&barrier, NULL, cfg_nr_threads);
+
+ for (i = 0; i < IP_MAXPACKET; i++)
+ payload[i] = 'a' + (i % 26);
+
+ for (i = 0; i < cfg_nr_threads; i++) {
+ td = &threads[i];
+ td->idx = i;
+ }
+
+ for (i = 0; i < cfg_nr_threads; i++)
+ pthread_create(&threads[i].thread, NULL, do_test, td);
+
+ for (i = 0; i < cfg_nr_threads; i++) {
+ td = &threads[i];
+ pthread_join(td->thread, &res);
+ packets += td->packets;
+ bytes += td->bytes;
+ }
+
+ fprintf(stderr, "tx=%llu (MB=%llu), tx/s=%llu (MB/s=%llu)\n",
+ packets, bytes >> 20,
+ packets / (cfg_runtime_ms / 1000),
+ (bytes >> 20) / (cfg_runtime_ms / 1000));
+
+ pthread_barrier_destroy(&barrier);
return 0;
}
--
2.39.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH liburing 3/3] examples/send-zc: add the receive part
2023-03-01 16:10 [PATCH liburing 0/3] sendzc test improvements Pavel Begunkov
2023-03-01 16:10 ` [PATCH liburing 1/3] examples/send-zc: add affinity / CPU pinning Pavel Begunkov
2023-03-01 16:10 ` [PATCH liburing 2/3] examples/send-zc: add multithreading Pavel Begunkov
@ 2023-03-01 16:10 ` Pavel Begunkov
2023-03-01 20:00 ` [PATCH liburing 0/3] sendzc test improvements Jens Axboe
3 siblings, 0 replies; 6+ messages in thread
From: Pavel Begunkov @ 2023-03-01 16:10 UTC (permalink / raw)
To: io-uring; +Cc: Jens Axboe, asml.silence
'-R' will switch the benchmark into the server mode accepting data. For
TCP the number of threads should match the number of threads of the
client. For UDP just one thread/connection should be enough.
Signed-off-by: Pavel Begunkov <[email protected]>
---
examples/send-zerocopy.c | 146 ++++++++++++++++++++++++++++++++++++++-
1 file changed, 143 insertions(+), 3 deletions(-)
diff --git a/examples/send-zerocopy.c b/examples/send-zerocopy.c
index c0549a1..75e516c 100644
--- a/examples/send-zerocopy.c
+++ b/examples/send-zerocopy.c
@@ -13,6 +13,7 @@
#include <string.h>
#include <pthread.h>
+#include <poll.h>
#include <sched.h>
#include <arpa/inet.h>
#include <linux/errqueue.h>
@@ -53,6 +54,7 @@ struct thread_data {
unsigned long long packets;
unsigned long long bytes;
struct sockaddr_storage dst_addr;
+ int fd;
};
static bool cfg_reg_ringfd = true;
@@ -63,6 +65,7 @@ static bool cfg_fixed_buf = 1;
static bool cfg_hugetlb = 0;
static bool cfg_defer_taskrun = 0;
static int cfg_cpu = -1;
+static bool cfg_rx = 0;
static unsigned cfg_nr_threads = 1;
static int cfg_family = PF_UNSPEC;
@@ -165,6 +168,135 @@ static void setup_sockaddr(int domain, const char *str_addr,
}
}
+static int do_poll(int fd, int events)
+{
+ struct pollfd pfd;
+ int ret;
+
+ pfd.events = events;
+ pfd.revents = 0;
+ pfd.fd = fd;
+
+ ret = poll(&pfd, 1, -1);
+ if (ret == -1)
+ t_error(1, errno, "poll");
+
+ return ret && (pfd.revents & events);
+}
+
+/* Flush all outstanding bytes for the tcp receive queue */
+static int do_flush_tcp(struct thread_data *td, int fd)
+{
+ int ret;
+
+ /* MSG_TRUNC flushes up to len bytes */
+ ret = recv(fd, NULL, 1 << 21, MSG_TRUNC | MSG_DONTWAIT);
+ if (ret == -1 && errno == EAGAIN)
+ return 0;
+ if (ret == -1)
+ t_error(1, errno, "flush");
+ if (!ret)
+ return 1;
+
+ td->packets++;
+ td->bytes += ret;
+ return 0;
+}
+
+/* Flush all outstanding datagrams. Verify first few bytes of each. */
+static int do_flush_datagram(struct thread_data *td, int fd, int type)
+{
+ int ret, off = 0;
+ char buf[64];
+
+ /* MSG_TRUNC will return full datagram length */
+ ret = recv(fd, buf, sizeof(buf), MSG_DONTWAIT | MSG_TRUNC);
+ if (ret == -1 && errno == EAGAIN)
+ return 0;
+
+ if (ret == -1)
+ t_error(1, errno, "recv");
+ if (ret != cfg_payload_len)
+ t_error(1, 0, "recv: ret=%u != %u", ret, cfg_payload_len);
+ if (ret > sizeof(buf) - off)
+ ret = sizeof(buf) - off;
+ if (memcmp(buf + off, payload, ret))
+ t_error(1, 0, "recv: data mismatch");
+
+ td->packets++;
+ td->bytes += cfg_payload_len;
+ return 0;
+}
+
+static void do_setup_rx(int domain, int type, int protocol)
+{
+ struct sockaddr_storage addr = {};
+ struct thread_data *td;
+ int listen_fd, fd, i;
+
+ fd = socket(domain, type, protocol);
+ if (fd == -1)
+ t_error(1, errno, "socket r");
+
+ do_setsockopt(fd, SOL_SOCKET, SO_RCVBUF, 1 << 21);
+ do_setsockopt(fd, SOL_SOCKET, SO_RCVLOWAT, 1 << 16);
+ do_setsockopt(fd, SOL_SOCKET, SO_REUSEPORT, 1);
+
+ setup_sockaddr(cfg_family, str_addr, &addr);
+
+ if (bind(fd, (void *)&addr, cfg_alen))
+ t_error(1, errno, "bind");
+
+ if (type != SOCK_STREAM) {
+ if (cfg_nr_threads != 1)
+ t_error(1, 0, "udp rx cant multithread");
+ threads[0].fd = fd;
+ return;
+ }
+
+ listen_fd = fd;
+ if (listen(listen_fd, cfg_nr_threads))
+ t_error(1, errno, "listen");
+
+ for (i = 0; i < cfg_nr_threads; i++) {
+ td = &threads[i];
+
+ fd = accept(listen_fd, NULL, NULL);
+ if (fd == -1)
+ t_error(1, errno, "accept");
+ td->fd = fd;
+ }
+
+ if (close(listen_fd))
+ t_error(1, errno, "close listen sock");
+}
+
+static void *do_rx(void *arg)
+{
+ struct thread_data *td = arg;
+ const int cfg_receiver_wait_ms = 400;
+ uint64_t tstop;
+ int ret, fd = td->fd;
+
+ tstop = gettimeofday_ms() + cfg_runtime_ms + cfg_receiver_wait_ms;
+ do {
+ if (cfg_type == SOCK_STREAM)
+ ret = do_flush_tcp(td, fd);
+ else
+ ret = do_flush_datagram(td, fd, cfg_type);
+
+ if (ret)
+ break;
+
+ do_poll(fd, POLLIN);
+ } while (gettimeofday_ms() < tstop);
+
+ if (close(fd))
+ t_error(1, errno, "close");
+ pthread_exit(&td->ret);
+ return NULL;
+}
+
static inline struct io_uring_cqe *wait_cqe_fast(struct io_uring *ring)
{
struct io_uring_cqe *cqe;
@@ -284,7 +416,7 @@ static void do_tx(struct thread_data *td, int domain, int type, int protocol)
td->bytes += cqe->res;
} else if (cqe->res == -ECONNREFUSED || cqe->res == -EPIPE ||
cqe->res == -ECONNRESET) {
- fprintf(stderr, "Connection failure");
+ fprintf(stderr, "Connection failure\n");
goto out_fail;
} else if (cqe->res != -EAGAIN) {
t_error(1, cqe->res, "send failed");
@@ -317,6 +449,7 @@ static void *do_test(void *arg)
do_tx(td, cfg_family, cfg_type, protocol);
pthread_exit(&td->ret);
+ return NULL;
}
static void usage(const char *filepath)
@@ -339,7 +472,7 @@ static void parse_opts(int argc, char **argv)
cfg_payload_len = max_payload_len;
- while ((c = getopt(argc, argv, "46D:p:s:t:n:z:b:l:dC:T:")) != -1) {
+ while ((c = getopt(argc, argv, "46D:p:s:t:n:z:b:l:dC:T:R")) != -1) {
switch (c) {
case '4':
if (cfg_family != PF_UNSPEC)
@@ -388,6 +521,9 @@ static void parse_opts(int argc, char **argv)
if (cfg_nr_threads > MAX_THREADS)
t_error(1, 0, "too many threads\n");
break;
+ case 'R':
+ cfg_rx = 1;
+ break;
}
}
@@ -442,8 +578,12 @@ int main(int argc, char **argv)
td->idx = i;
}
+ if (cfg_rx)
+ do_setup_rx(cfg_family, cfg_type, 0);
+
for (i = 0; i < cfg_nr_threads; i++)
- pthread_create(&threads[i].thread, NULL, do_test, td);
+ pthread_create(&threads[i].thread, NULL,
+ !cfg_rx ? do_test : do_rx, &threads[i]);
for (i = 0; i < cfg_nr_threads; i++) {
td = &threads[i];
--
2.39.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH liburing 0/3] sendzc test improvements
2023-03-01 16:10 [PATCH liburing 0/3] sendzc test improvements Pavel Begunkov
` (2 preceding siblings ...)
2023-03-01 16:10 ` [PATCH liburing 3/3] examples/send-zc: add the receive part Pavel Begunkov
@ 2023-03-01 20:00 ` Jens Axboe
2023-03-01 20:31 ` Pavel Begunkov
3 siblings, 1 reply; 6+ messages in thread
From: Jens Axboe @ 2023-03-01 20:00 UTC (permalink / raw)
To: Pavel Begunkov, io-uring
On 3/1/23 9:10 AM, Pavel Begunkov wrote:
> Add affinity, multithreading and the server
>
> Pavel Begunkov (3):
> examples/send-zc: add affinity / CPU pinning
> examples/send-zc: add multithreading
> examples/send-zc: add the receive part
>
> examples/Makefile | 3 +
> examples/send-zerocopy.c | 277 ++++++++++++++++++++++++++++++++++-----
> 2 files changed, 249 insertions(+), 31 deletions(-)
This doesn't apply to the current tree, what am I missing? I
don't see any send-zc changes since the last ones you did.
First patch:
axboe@m1max ~/gi/liburing (master)> patch -p1 --dry-run < 1
checking file examples/send-zerocopy.c
Hunk #1 succeeded at 12 with fuzz 2.
Hunk #2 FAILED at 51.
Hunk #3 succeeded at 78 (offset -2 lines).
Hunk #4 succeeded at 192 (offset -7 lines).
Hunk #5 FAILED at 333.
Hunk #6 succeeded at 360 with fuzz 2 (offset -14 lines).
Hunk #7 succeeded at 382 (offset -14 lines).
2 out of 7 hunks FAILED
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH liburing 0/3] sendzc test improvements
2023-03-01 20:00 ` [PATCH liburing 0/3] sendzc test improvements Jens Axboe
@ 2023-03-01 20:31 ` Pavel Begunkov
0 siblings, 0 replies; 6+ messages in thread
From: Pavel Begunkov @ 2023-03-01 20:31 UTC (permalink / raw)
To: Jens Axboe, io-uring
On 3/1/23 20:00, Jens Axboe wrote:
> On 3/1/23 9:10 AM, Pavel Begunkov wrote:
>> Add affinity, multithreading and the server
>>
>> Pavel Begunkov (3):
>> examples/send-zc: add affinity / CPU pinning
>> examples/send-zc: add multithreading
>> examples/send-zc: add the receive part
>>
>> examples/Makefile | 3 +
>> examples/send-zerocopy.c | 277 ++++++++++++++++++++++++++++++++++-----
>> 2 files changed, 249 insertions(+), 31 deletions(-)
>
> This doesn't apply to the current tree, what am I missing? I
> don't see any send-zc changes since the last ones you did.
> First patch:
Don't know what that is, I'll resend later
> axboe@m1max ~/gi/liburing (master)> patch -p1 --dry-run < 1
> checking file examples/send-zerocopy.c
> Hunk #1 succeeded at 12 with fuzz 2.
> Hunk #2 FAILED at 51.
> Hunk #3 succeeded at 78 (offset -2 lines).
> Hunk #4 succeeded at 192 (offset -7 lines).
> Hunk #5 FAILED at 333.
> Hunk #6 succeeded at 360 with fuzz 2 (offset -14 lines).
> Hunk #7 succeeded at 382 (offset -14 lines).
> 2 out of 7 hunks FAILED
>
--
Pavel Begunkov
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-01 20:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-01 16:10 [PATCH liburing 0/3] sendzc test improvements Pavel Begunkov
2023-03-01 16:10 ` [PATCH liburing 1/3] examples/send-zc: add affinity / CPU pinning Pavel Begunkov
2023-03-01 16:10 ` [PATCH liburing 2/3] examples/send-zc: add multithreading Pavel Begunkov
2023-03-01 16:10 ` [PATCH liburing 3/3] examples/send-zc: add the receive part Pavel Begunkov
2023-03-01 20:00 ` [PATCH liburing 0/3] sendzc test improvements Jens Axboe
2023-03-01 20:31 ` Pavel Begunkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox