From: Martin Raiber <[email protected]>
To: Linus Torvalds <[email protected]>,
Jens Axboe <[email protected]>
Cc: Martin Raiber <[email protected]>,
Pavel Begunkov <[email protected]>,
io-uring <[email protected]>
Subject: Re: Fixed buffers have out-dated content
Date: Sun, 17 Jan 2021 20:07:41 +0000 [thread overview]
Message-ID: <0102017711f5dc95-8153416f-4641-4495-9103-82c2744e0d69-000000@eu-west-1.amazonses.com> (raw)
In-Reply-To: <CAHk-=wiGEFZf-+YXcUVDj_mutwG6qWZzKUKZ-5yQ5UWgLGrBNQ@mail.gmail.com>
On 17.01.2021 00:34 Linus Torvalds wrote:
> On Sat, Jan 16, 2021 at 3:05 PM Linus Torvalds
> <[email protected]> wrote:
>> I'll go think about this.
>>
>> Martin, since you can apparently trigger the problem easily, hopefully
>> you're willing to try a couple of patches?
> Hmm. It might end up being as simple as the attached patch.
>
> I'm not super-happy with this situation (that whole nasty security
> issue had some horrible cascading problems), and this only really
> fixes _pinned_ pages.
>
> In particular, somebody doing a plain get_user_pages() for writing can
> still hit issues (admittedly that's true in general, but the vm
> changes made it much more obviously true).
>
> But for the case of io_uring buffers, this looks like the obvious simple fix.
>
> I don't have a load to test this with, so I'll come back to ask Martin
> to do so...
>
> Linus
Thanks! With the patch (skip swapping pinned pages) the problem doesn't
occur anymore, so it seems to fix it.
next prev parent reply other threads:[~2021-01-17 20:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 23:39 Fixed buffer have out-dated content Martin Raiber
2021-01-09 16:23 ` Jens Axboe
2021-01-09 16:58 ` Martin Raiber
2021-01-09 20:32 ` Pavel Begunkov
2021-01-10 16:50 ` Martin Raiber
2021-01-14 21:50 ` Fixed buffers " Martin Raiber
2021-01-16 19:30 ` Pavel Begunkov
2021-01-16 19:39 ` Jens Axboe
2021-01-16 22:12 ` Jens Axboe
2021-01-16 23:05 ` Linus Torvalds
2021-01-16 23:34 ` Linus Torvalds
2021-01-17 20:07 ` Martin Raiber [this message]
2021-01-17 20:14 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0102017711f5dc95-8153416f-4641-4495-9103-82c2744e0d69-000000@eu-west-1.amazonses.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox