* [PATCH] io_uring: don't double complete failed reissue request
@ 2020-11-17 15:02 Jens Axboe
0 siblings, 0 replies; only message in thread
From: Jens Axboe @ 2020-11-17 15:02 UTC (permalink / raw)
To: io-uring
Zorro reports that an xfstest test case is failing, and it turns out that
for the reissue path we can potentially issue a double completion on the
request for the failure path. There's an issue around the retry as well,
but for now, at least just make sure that we handle the error path
correctly.
Reported-by: Zorro Lang <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
---
diff --git a/fs/io_uring.c b/fs/io_uring.c
index f05978a74ce1..b205c1df3f74 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2578,7 +2578,6 @@ static bool io_resubmit_prep(struct io_kiocb *req, int error)
}
end_req:
req_set_fail_links(req);
- io_req_complete(req, ret);
return false;
}
#endif
--
Jens Axboe
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-11-17 15:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-17 15:02 [PATCH] io_uring: don't double complete failed reissue request Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox