From: Stefan Metzmacher <[email protected]>
To: Jens Axboe <[email protected]>,
Linus Torvalds <[email protected]>,
"Eric W. Biederman" <[email protected]>
Cc: io-uring <[email protected]>,
Linux Kernel Mailing List <[email protected]>,
Oleg Nesterov <[email protected]>
Subject: Re: [PATCH 0/2] Don't show PF_IO_WORKER in /proc/<pid>/task/
Date: Fri, 26 Mar 2021 12:59:17 +0100 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
Hi Jens,
>> And /proc/$iothread/ should be read only and owned by root with
>> "cmdline" and "exe" being empty.
>
> I know you brought this one up as part of your series, not sure I get
> why you want it owned by root and read-only? cmdline and exe, yeah those
> could be hidden, but is there really any point?
>
> Maybe I'm missing something here, if so, do clue me in!
I looked through /proc and I think it's mostly similar to
the unshare() case, if userspace wants to do stupid things
like changing "comm" of iothreads, it gets what was asked for.
But the "cmdline" hiding would be very useful.
While most tools use "comm", by default.
ps -eLf or 'iotop' use "cmdline".
Some processes use setproctitle to change "cmdline" in order
to identify the process better, without the 15 chars comm restriction,
that's why I very often press 'c' in 'top' to see the cmdline,
in that case it would be very helpful to see '[iou-wrk-1234]'
instead of the seeing the cmdline.
So I'd very much prefer if this could be applied:
https://lore.kernel.org/io-uring/d4487f959c778d0b1d4c5738b75bcff17d21df5b.1616197787.git.metze@samba.org/T/#u
If you want I can add a comment and a more verbose commit message...
metze
next prev parent reply other threads:[~2021-03-26 12:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 16:43 [PATCH 0/2] Don't show PF_IO_WORKER in /proc/<pid>/task/ Jens Axboe
2021-03-25 16:43 ` [PATCH 1/2] kernel: don't include PF_IO_WORKERs as part of same_thread_group() Jens Axboe
2021-03-25 16:43 ` [PATCH 2/2] proc: don't show PF_IO_WORKER threads as threads in /proc/<pid>/task/ Jens Axboe
2021-03-25 19:33 ` [PATCH 0/2] Don't show PF_IO_WORKER " Eric W. Biederman
2021-03-25 19:38 ` Linus Torvalds
2021-03-25 19:40 ` Jens Axboe
2021-03-25 19:42 ` Linus Torvalds
2021-03-25 19:46 ` Jens Axboe
2021-03-25 20:21 ` Eric W. Biederman
2021-03-25 20:40 ` Oleg Nesterov
2021-03-25 20:43 ` Jens Axboe
2021-03-25 20:48 ` Eric W. Biederman
2021-03-25 20:42 ` Jens Axboe
2021-03-25 20:12 ` Linus Torvalds
2021-03-25 20:40 ` Jens Axboe
2021-03-25 21:44 ` Jens Axboe
2021-03-25 21:57 ` Stefan Metzmacher
2021-03-26 0:11 ` Jens Axboe
2021-03-26 11:59 ` Stefan Metzmacher [this message]
2021-04-01 14:40 ` Stefan Metzmacher
2021-03-25 22:37 ` Linus Torvalds
2021-03-26 0:08 ` Jens Axboe
2021-03-25 20:43 ` Eric W. Biederman
2021-03-25 21:50 ` Jens Axboe
2021-03-25 20:44 ` Oleg Nesterov
2021-03-25 20:55 ` Eric W. Biederman
2021-03-25 21:20 ` Stefan Metzmacher
2021-03-25 21:48 ` Stefan Metzmacher
2021-03-25 19:40 ` Jens Axboe
2021-03-25 20:32 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox