From: ALOK TIWARI <alok.a.tiwari@oracle.com>
To: bschubert@ddn.com, miklos@szeredi.hu,
linux-fsdevel@vger.kernel.org, asml.silence@gmail.com,
luis@igalia.com, io-uring@vger.kernel.org
Cc: alok.a.tiwari@oracle.com
Subject: [query] payload size check in fuse_uring_create_ring_ent
Date: Mon, 27 Oct 2025 20:19:10 +0530 [thread overview]
Message-ID: <04b7104c-95e3-4b0c-a8a2-f240a1994c68@oracle.com> (raw)
Hi,
I am wondering if this condition is intentional.
It seems that ring->max_payload_sz represents the maximum allowed
payload size, so rejecting payloads smaller than that looks unexpected.
Could you please confirm whether the current < check is correct or
if this should be > instead?
24fe962c86f5 ("fuse: {io-uring} Handle SQEs - register commands")
Thanks,
Alok
---
diff --git a/fs/fuse/dev_uring.c b/fs/fuse/dev_uring.c
index f6b12aebb8bb..4106fc80c1e8 100644
--- a/fs/fuse/dev_uring.c
+++ b/fs/fuse/dev_uring.c
@@ -1051,7 +1051,7 @@ fuse_uring_create_ring_ent(struct io_uring_cmd *cmd,
}
payload_size = iov[1].iov_len;
- if (payload_size < ring->max_payload_sz) {
+ if (payload_size > ring->max_payload_sz) {
pr_info_ratelimited("Invalid req payload len %zu\n",
payload_size);
next reply other threads:[~2025-10-27 14:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 14:49 ALOK TIWARI [this message]
2025-10-27 14:59 ` [query] payload size check in fuse_uring_create_ring_ent Bernd Schubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04b7104c-95e3-4b0c-a8a2-f240a1994c68@oracle.com \
--to=alok.a.tiwari@oracle.com \
--cc=asml.silence@gmail.com \
--cc=bschubert@ddn.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=luis@igalia.com \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox