From: Jens Axboe <[email protected]>
To: Dylan Yudaken <[email protected]>, [email protected]
Cc: [email protected], [email protected]
Subject: Re: [PATCH liburing 5/5] overflow: add tests
Date: Thu, 21 Apr 2022 13:49:03 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 4/21/22 3:14 AM, Dylan Yudaken wrote:
> Add tests that verify that overflow conditions behave appropriately.
> Specifically:
> * if overflow is continually flushed, then CQEs should arrive mostly in
> order to prevent starvation of some completions
> * if CQEs are dropped due to GFP_ATOMIC allocation failures it is
> possible to terminate cleanly. This is not tested by default as it
> requires debug kernel config, and also has system-wide effects
Since you're doing a v2 of this anyway, can we change:
> +/*
> + * Create an overflow condition and ensure that SQEs are still processed
> + */
> +static int test_overflow_handling(
> + bool batch,
> + int cqe_multiple,
> + bool poll)
> +{
to follow the normal stye of:
static int test_overflow_handling(bool batch, int cqe_multiple, bool poll)
{
instead?
--
Jens Axboe
prev parent reply other threads:[~2022-04-21 19:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 9:14 [PATCH liburing 0/5] overflow support Dylan Yudaken
2022-04-21 9:14 ` [PATCH liburing 1/5] fix documentation shortenings Dylan Yudaken
2022-04-21 9:14 ` [PATCH liburing 2/5] update io_uring_enter.2 docs for IORING_FEAT_NODROP Dylan Yudaken
2022-04-21 9:14 ` [PATCH liburing 3/5] expose CQ ring overflow state Dylan Yudaken
2022-04-21 9:14 ` [PATCH liburing 4/5] add docs for overflow lost errors Dylan Yudaken
2022-04-21 9:14 ` [PATCH liburing 5/5] overflow: add tests Dylan Yudaken
2022-04-21 11:44 ` Ammar Faizi
2022-04-21 13:04 ` Dylan Yudaken
2022-04-21 19:49 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox