From: Xi Ruoyao <[email protected]>
To: Mateusz Guzik <[email protected]>, [email protected]
Cc: [email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected]
Subject: Re: [PATCH v3] vfs: support statx(..., NULL, AT_EMPTY_PATH, ...)
Date: Wed, 26 Jun 2024 10:59:50 +0800 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On Tue, 2024-06-25 at 17:18 +0200, Mateusz Guzik wrote:
> + if ((sx->flags & (AT_EMPTY_PATH | AT_STATX_SYNC_TYPE)) ==
> + (AT_EMPTY_PATH | AT_STATX_SYNC_TYPE) &&
> + vfs_empty_path(sx->dfd, path)) {
> sx->filename = NULL;
> - return ret;
AT_STATX_SYNC_TYPE == AT_STATX_FORCE_SYNC | AT_STATX_DONT_SYNC but
AT_STATX_FORCE_SYNC and AT_STATX_DONT_SYNC obviously contradicts with
each other. Thus valid uses of statx won't satisfy this condition.
And I guess the condition here should be same as the condition in
SYSCALL_DEFINE5(statx) or am I wrong?
--
Xi Ruoyao <[email protected]>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2024-06-26 2:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 15:18 [PATCH v3] vfs: support statx(..., NULL, AT_EMPTY_PATH, ...) Mateusz Guzik
2024-06-26 2:59 ` Xi Ruoyao [this message]
2024-06-26 13:39 ` Mateusz Guzik
2024-06-26 14:35 ` Christian Brauner
2024-06-26 15:02 ` Jens Axboe
2024-06-26 3:15 ` Xi Ruoyao
2024-06-26 13:05 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0763d386dfd0d4b4a28744bac744b5e823144f0b.camel@xry111.site \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox