From: Xiaoguang Wang <[email protected]>
To: Jens Axboe <[email protected]>, [email protected]
Cc: [email protected]
Subject: Re: [PATCH v2] io_uring: defer alloc_hint update to io_file_bitmap_set()
Date: Sat, 28 May 2022 09:45:30 +0800 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
hi,
> On 5/27/22 11:39 AM, Xiaoguang Wang wrote:
>> io_file_bitmap_get() returns a free bitmap slot, but if it isn't
>> used later, such as io_queue_rsrc_removal() returns error, in this
>> case, we should not update alloc_hint at all, which still should
>> be considered as a valid candidate for next io_file_bitmap_get()
>> calls.
>>
>> To fix this issue, only update alloc_hint in io_file_bitmap_set().
> Why are you changing the io_file_bitmap_set() type?
Oh sorry, it was introduced in patch v1 to check whether alloc_hint
is greater than nr_user_files, but forgot to revert it in patch v2.
Regards,
Xiaoguang Wang
>
>
next prev parent reply other threads:[~2022-05-28 1:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 16:53 [PATCH 0/2] two bug fixes about direct fd install Xiaoguang Wang
2022-05-27 16:53 ` [PATCH 1/2] io_uring: fix file leaks around io_fixed_fd_install() Xiaoguang Wang
2022-05-27 17:00 ` Jens Axboe
2022-05-27 16:53 ` [PATCH 2/2] io_uring: defer alloc_hint update to io_file_bitmap_set() Xiaoguang Wang
2022-05-27 17:09 ` Jens Axboe
2022-05-27 17:39 ` [PATCH v2] " Xiaoguang Wang
2022-05-27 18:03 ` Jens Axboe
2022-05-28 1:45 ` Xiaoguang Wang [this message]
2022-05-28 1:51 ` [PATCH v3] " Xiaoguang Wang
2022-05-28 2:14 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=076bc71c-673f-ecda-a3b9-31e0040d7ef9@linux.alibaba.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox