From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, io-uring@vger.kernel.org
Subject: Re: [PATCH 3/5] io_uring: consider ring dead once the ref is marked dying
Date: Wed, 9 Apr 2025 10:15:39 +0100 [thread overview]
Message-ID: <07b0ced0-cbf6-44a6-add0-e0cb1854cde2@gmail.com> (raw)
In-Reply-To: <27a391b1-80a1-43ae-9550-73f48c1b8fea@kernel.dk>
On 4/8/25 20:22, Jens Axboe wrote:
> (getting back to this post the merge window)
>
> On 3/21/25 3:22 PM, Pavel Begunkov wrote:
>> On 3/21/25 19:24, Jens Axboe wrote:
>>> Don't gate this on the task exiting flag. It's generally not a good idea
>>
>> Do you refer to tw add and the PF_EXITING logic inside? We can't gate
>> it solely on dying refs as it's not sync'ed (and the patch doesn't).
>> And task is dying is not same as ring is closed. E.g. a task can
>> exit(2) but leave the ring intact to other tasks.
>
> It's not gated solely on dying refs, it's an addition.
Right, which is why the commit message stating "don't gate on the
task exiting flag" and leaving it gated on the task exiting flag
is confusing.
--
Pavel Begunkov
next prev parent reply other threads:[~2025-04-09 9:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 19:24 [PATCHSET RFC v2 0/5] Cancel and wait for all requests on exit Jens Axboe
2025-03-21 19:24 ` [PATCH 1/5] fs: gate final fput task_work on PF_NO_TASKWORK Jens Axboe
2025-03-21 19:24 ` [PATCH 2/5] io_uring: mark exit side kworkers as task_work capable Jens Axboe
2025-03-21 19:24 ` [PATCH 3/5] io_uring: consider ring dead once the ref is marked dying Jens Axboe
2025-03-21 21:22 ` Pavel Begunkov
2025-04-08 19:22 ` Jens Axboe
2025-04-09 9:15 ` Pavel Begunkov [this message]
2025-04-09 13:15 ` Jens Axboe
2025-03-21 19:24 ` [PATCH 4/5] io_uring: wait for cancelations on final ring put Jens Axboe
2025-03-21 19:24 ` [PATCH 5/5] io_uring: switch away from percpu refcounts Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2025-04-09 13:35 [PATCHSET v3 0/5] Cancel and wait for all requests on exit Jens Axboe
2025-04-09 13:35 ` [PATCH 3/5] io_uring: consider ring dead once the ref is marked dying Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07b0ced0-cbf6-44a6-add0-e0cb1854cde2@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox