public inbox for [email protected]
 help / color / mirror / Atom feed
From: Ammar Faizi <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Stefan Metzmacher <[email protected]>,
	Pavel Begunkov <[email protected]>,
	io-uring Mailing List <[email protected]>
Subject: Re: [PATCH v2 1/1] uapi:io_uring.h: allow linux/time_types.h to be skipped
Date: Fri, 18 Nov 2022 00:53:02 +0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <7071a0a1d751221538b20b63f9160094fc7e06f4.1668630247.git.metze@samba.org>

On 11/17/22 3:25 AM, Stefan Metzmacher wrote:
> diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h
> index 551e75908f33..082020257f19 100644
> --- a/include/uapi/linux/io_uring.h
> +++ b/include/uapi/linux/io_uring.h
> @@ -10,7 +10,15 @@
>   
>   #include <linux/fs.h>
>   #include <linux/types.h>
> +/*
> + * this file is shared with liburing and that has to autodetect
> + * if linux/time_types.h is available or not, it can
> + * define UAPI_LINUX_IO_URING_H_SKIP_LINUX_TIME_TYPES_H
> + * if linux/time_types.h is not available
> + */
> +#ifndef UAPI_LINUX_IO_URING_H_SKIP_LINUX_TIME_TYPES_H
>   #include <linux/time_types.h>
> +#endif
>   
>   #ifdef __cplusplus
>   extern "C" {

I admit the v1 was a stupid mistake. Sorry for that. Now this change
should not have any effect on the kernel code.

Only apps that use io_uring.h and put:

   #define UAPI_LINUX_IO_URING_H_SKIP_LINUX_TIME_TYPES_H

before the #include will get the effect, which Stefan will do in
liburing once this one gets accepted.

Reviewed-by: Ammar Faizi <[email protected]>

-- 
Ammar Faizi


  reply	other threads:[~2022-11-17 17:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <[email protected]>
2022-11-16 20:25 ` [PATCH v2 1/1] uapi:io_uring.h: allow linux/time_types.h to be skipped Stefan Metzmacher
2022-11-17 17:53   ` Ammar Faizi [this message]
2022-12-27 10:06   ` Stefan Metzmacher
2022-12-27 14:33   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox