From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB3B4C4332F for ; Thu, 17 Nov 2022 17:53:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231240AbiKQRxf (ORCPT ); Thu, 17 Nov 2022 12:53:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240254AbiKQRxL (ORCPT ); Thu, 17 Nov 2022 12:53:11 -0500 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0998A7FC2F for ; Thu, 17 Nov 2022 09:53:07 -0800 (PST) Received: from [10.7.7.5] (unknown [182.253.183.240]) by gnuweeb.org (Postfix) with ESMTPSA id 446AD81652; Thu, 17 Nov 2022 17:53:05 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1668707586; bh=l5xMKBZdppFPi4ovTtvIyXdvrR8vUBABu4PUQKmz+P4=; h=Date:To:Cc:References:From:Subject:In-Reply-To:From; b=MX6eq/8vkSWs+ws46lgC+JQMqQEGzdtIi+3qcDWkDyaKSvTXVNhMoNm6aAQdFjSfn 3MBKOG4QwZO3387wXFNixVbWh3JO3FxI8jFg2JGEkFMn8bId1Ht/t1CipJq+yq7zGm cLkkGzsNvMYg/p5M+Pq7qJtcorOwpRg5Bdl1KRSYkaTDkdsvfC7c6ETcuW9bQBGqJk tNTUnBDVKNh+ToT57iWNSaTjzAgXjWCExu61YIL3HhcoCFoQic9Sl3y+ZRBfTzqvp4 CUgb9LqGTudl0GX7fMqfdGqVnV5ARn5bMDq9sqXJ/bkfxrY42cK5ueoq501XqUjtkj TjPNNbS/WJqrw== Message-ID: <085800fc-184f-3e94-930f-a5f9d4a91d34@gnuweeb.org> Date: Fri, 18 Nov 2022 00:53:02 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US To: Jens Axboe Cc: Stefan Metzmacher , Pavel Begunkov , io-uring Mailing List References: <7071a0a1d751221538b20b63f9160094fc7e06f4.1668630247.git.metze@samba.org> From: Ammar Faizi Subject: Re: [PATCH v2 1/1] uapi:io_uring.h: allow linux/time_types.h to be skipped In-Reply-To: <7071a0a1d751221538b20b63f9160094fc7e06f4.1668630247.git.metze@samba.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 11/17/22 3:25 AM, Stefan Metzmacher wrote: > diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h > index 551e75908f33..082020257f19 100644 > --- a/include/uapi/linux/io_uring.h > +++ b/include/uapi/linux/io_uring.h > @@ -10,7 +10,15 @@ > > #include > #include > +/* > + * this file is shared with liburing and that has to autodetect > + * if linux/time_types.h is available or not, it can > + * define UAPI_LINUX_IO_URING_H_SKIP_LINUX_TIME_TYPES_H > + * if linux/time_types.h is not available > + */ > +#ifndef UAPI_LINUX_IO_URING_H_SKIP_LINUX_TIME_TYPES_H > #include > +#endif > > #ifdef __cplusplus > extern "C" { I admit the v1 was a stupid mistake. Sorry for that. Now this change should not have any effect on the kernel code. Only apps that use io_uring.h and put: #define UAPI_LINUX_IO_URING_H_SKIP_LINUX_TIME_TYPES_H before the #include will get the effect, which Stefan will do in liburing once this one gets accepted. Reviewed-by: Ammar Faizi -- Ammar Faizi