From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Cc: Alexey Charkov <alchark@gmail.com>
Subject: Re: [PATCH 1/1] io_uring/zcrx: fix builds without dmabuf
Date: Tue, 6 May 2025 10:11:47 -0600 [thread overview]
Message-ID: <08c18157-c180-4034-bf21-61f0b11af95d@kernel.dk> (raw)
In-Reply-To: <e6e7f396-9eb2-4990-927b-d4256494e669@gmail.com>
On 5/6/25 10:10 AM, Pavel Begunkov wrote:
> On 5/6/25 17:08, Pavel Begunkov wrote:
>> armv7a-unknown-linux-gnueabihf-ld: io_uring/zcrx.o: in function
>> `io_release_dmabuf':
>> zcrx.c:(.text+0x1c): undefined reference to `dma_buf_unmap_attachment_unlocked'
>> armv7a-unknown-linux-gnueabihf-ld: zcrx.c:(.text+0x30): undefined
>> reference to `dma_buf_detach'
>> armv7a-unknown-linux-gnueabihf-ld: zcrx.c:(.text+0x40): undefined
>> reference to `dma_buf_put'
>> armv7a-unknown-linux-gnueabihf-ld: io_uring/zcrx.o: in function
>> `io_register_zcrx_ifq':
>> zcrx.c:(.text+0x15cc): undefined reference to `dma_buf_get'
>> armv7a-unknown-linux-gnueabihf-ld: zcrx.c:(.text+0x15e8): undefined
>> reference to `dma_buf_attach'
>> armv7a-unknown-linux-gnueabihf-ld: zcrx.c:(.text+0x1604): undefined
>> reference to `dma_buf_map_attachment_unlocked'
>> make[2]: *** [scripts/Makefile.vmlinux:91: vmlinux] Error 1
>> make[1]: *** [/home/alchark/linux/Makefile:1242: vmlinux] Error 2
>> make: *** [Makefile:248: __sub-make] Error 2
>>
>> There are no definitions for dma-buf functions without
>> CONFIG_DMA_SHARED_BUFFER, make sure we don't try to link to them
>> if dma-bufs are not enabled.
>
> Jens, you'd probably want to squash it into a42c735833315bbe7a54
> ("io_uring/zcrx: dmabuf backed zerocopy receive")
Done, added the new link too.
--
Jens Axboe
next prev parent reply other threads:[~2025-05-06 16:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 16:08 [PATCH 1/1] io_uring/zcrx: fix builds without dmabuf Pavel Begunkov
2025-05-06 16:10 ` Pavel Begunkov
2025-05-06 16:11 ` Jens Axboe [this message]
2025-05-06 16:58 ` Alexey Charkov
2025-05-07 7:35 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08c18157-c180-4034-bf21-61f0b11af95d@kernel.dk \
--to=axboe@kernel.dk \
--cc=alchark@gmail.com \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox