public inbox for [email protected]
 help / color / mirror / Atom feed
From: Pavel Begunkov <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: [PATCH v3 9/9] io_uring: cap cached iovec/bvec size
Date: Fri,  7 Mar 2025 15:49:10 +0000	[thread overview]
Message-ID: <097f9237221826b1eebf5b03336be176fd2ee0ca.1741361926.git.asml.silence@gmail.com> (raw)
In-Reply-To: <[email protected]>

Bvecs can be large, put an arbitrary limit on the max vector size it
can cache.

Signed-off-by: Pavel Begunkov <[email protected]>
---
 io_uring/net.c  | 3 +++
 io_uring/rsrc.h | 2 ++
 io_uring/rw.c   | 3 +++
 3 files changed, 8 insertions(+)

diff --git a/io_uring/net.c b/io_uring/net.c
index 5e27c22e1d58..ce104d04b1e4 100644
--- a/io_uring/net.c
+++ b/io_uring/net.c
@@ -152,6 +152,9 @@ static void io_netmsg_recycle(struct io_kiocb *req, unsigned int issue_flags)
 
 	/* Let normal cleanup path reap it if we fail adding to the cache */
 	io_alloc_cache_vec_kasan(&hdr->vec);
+	if (hdr->vec.nr > IO_VEC_CACHE_SOFT_CAP)
+		io_vec_free(&hdr->vec);
+
 	if (io_alloc_cache_put(&req->ctx->netmsg_cache, hdr)) {
 		req->async_data = NULL;
 		req->flags &= ~REQ_F_ASYNC_DATA;
diff --git a/io_uring/rsrc.h b/io_uring/rsrc.h
index f1496f7d844f..0bfcdba12617 100644
--- a/io_uring/rsrc.h
+++ b/io_uring/rsrc.h
@@ -6,6 +6,8 @@
 #include <linux/lockdep.h>
 #include <linux/io_uring_types.h>
 
+#define IO_VEC_CACHE_SOFT_CAP		256
+
 enum {
 	IORING_RSRC_FILE		= 0,
 	IORING_RSRC_BUFFER		= 1,
diff --git a/io_uring/rw.c b/io_uring/rw.c
index e62f4ce34171..bf35599d1078 100644
--- a/io_uring/rw.c
+++ b/io_uring/rw.c
@@ -150,6 +150,9 @@ static void io_rw_recycle(struct io_kiocb *req, unsigned int issue_flags)
 		return;
 
 	io_alloc_cache_vec_kasan(&rw->vec);
+	if (rw->vec.nr > IO_VEC_CACHE_SOFT_CAP)
+		io_vec_free(&rw->vec);
+
 	if (io_alloc_cache_put(&req->ctx->rw_cache, rw)) {
 		req->async_data = NULL;
 		req->flags &= ~REQ_F_ASYNC_DATA;
-- 
2.48.1


      parent reply	other threads:[~2025-03-07 15:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 15:49 [PATCH v3 0/9] Add support for vectored registered buffers Pavel Begunkov
2025-03-07 15:49 ` [PATCH v3 1/9] io_uring: introduce struct iou_vec Pavel Begunkov
2025-03-07 15:49 ` [PATCH v3 2/9] io_uring: add infra for importing vectored reg buffers Pavel Begunkov
2025-03-07 15:49 ` [PATCH v3 3/9] io_uring/rw: implement vectored registered rw Pavel Begunkov
2025-03-07 15:49 ` [PATCH v3 4/9] io_uring/rw: defer reg buf vec import Pavel Begunkov
2025-03-07 15:49 ` [PATCH v3 5/9] io_uring/net: combine msghdr copy Pavel Begunkov
2025-03-07 15:49 ` [PATCH v3 6/9] io_uring/net: pull vec alloc out of msghdr import Pavel Begunkov
2025-03-07 15:49 ` [PATCH v3 7/9] io_uring/net: convert to struct iou_vec Pavel Begunkov
2025-03-07 15:49 ` [PATCH v3 8/9] io_uring/net: implement vectored reg bufs for zctx Pavel Begunkov
2025-03-07 15:49 ` Pavel Begunkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=097f9237221826b1eebf5b03336be176fd2ee0ca.1741361926.git.asml.silence@gmail.com \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox