From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 008.lax.mailroute.net (008.lax.mailroute.net [199.89.1.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3293F133987; Fri, 18 Oct 2024 16:11:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729267893; cv=none; b=VaQdiA6uXnNT3W4sn0GKo5gs3werbXLJhEfACN1kK0PIxP/zhJQfCT6qqA1gjRVQanlw8I2gx8qHZgzhKul47QJpDPC93I0111/RQURCPaws7be3vi/RdAwXXWjI5KALU5EgaAfzzGQeJRqHyWOd69R+YI8H7AHWmnBrk03lH4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729267893; c=relaxed/simple; bh=sFOSvS9yUPDz43ddDEY+XeZrFdWX+17k7HigJqpHdio=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EkvfvXqIYVgrcRJcVyth/QW2niqOghsaCgbdeDJy1tQOhX6uimM7hfdvUEDe+t7uL+pWLWY4ajK7tPU9stiOC0zc/GAIJJLGRTkQE3GJu+MjBSK4rSq+NXnaioaR0w6K5WyQfKWmC1FKxafHoAcbgUekaFUbYIhLKSkocaeTttw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=2uVJSzJk; arc=none smtp.client-ip=199.89.1.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="2uVJSzJk" Received: from localhost (localhost [127.0.0.1]) by 008.lax.mailroute.net (Postfix) with ESMTP id 4XVV7l3Vzbz6ClSpy; Fri, 18 Oct 2024 16:11:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1729267883; x=1731859884; bh=kEmzdJ/Pc8ND50WdJniLJozP O03McgYyB0Bd/e0lB0g=; b=2uVJSzJkdlwNEqOpx9tmSMH+CPOezCQCNAoiyIPi 1U4b3IoNqFGi9NwxX+k2z24xxT4cUiEG98zI4htS4Wu59EwlBVDHr2xKdM3bf1eR 4EF2hGtuxBvFEXOWIbpGA1nZ/FolbIciC/JWngD0YyH9NqbhVYuvTQo+XYB/wO+Y 07AMTmLBf/cw/tm06LPqfLBPiRa0rFJiAZHzcJLT3FeC7T3Gm7c+RJVPHO1vU56h XW2PuHZEypIQPAVHM3M8NGfZ1h+llopdNalmX5Xs9jrRbDTMH4Qw1BJGB+mUJ77t 2mC06KRXxRlU1asJtRWoNw7Bjp6PGROMWkF5yir2fg/7+Q== X-Virus-Scanned: by MailRoute Received: from 008.lax.mailroute.net ([127.0.0.1]) by localhost (008.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id dCHz-rmM4GJs; Fri, 18 Oct 2024 16:11:23 +0000 (UTC) Received: from [100.66.154.22] (unknown [104.135.204.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 008.lax.mailroute.net (Postfix) with ESMTPSA id 4XVV7S1wb9z6ClSqP; Fri, 18 Oct 2024 16:11:13 +0000 (UTC) Message-ID: <09e672a2-4421-4637-bfdc-e1c46af4d0ad@acm.org> Date: Fri, 18 Oct 2024 09:11:11 -0700 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv8 1/6] block, fs: restore kiocb based write hint processing To: Keith Busch , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, axboe@kernel.dk, hch@lst.de, io-uring@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, joshi.k@samsung.com, javier.gonz@samsung.com, Nitesh Shetty , Hannes Reinecke , Keith Busch References: <20241017160937.2283225-1-kbusch@meta.com> <20241017160937.2283225-2-kbusch@meta.com> Content-Language: en-US From: Bart Van Assche In-Reply-To: <20241017160937.2283225-2-kbusch@meta.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/17/24 9:09 AM, Keith Busch wrote: > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 3559446279c15..04e875a37f604 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -370,6 +370,7 @@ struct kiocb { > void *private; > int ki_flags; > u16 ki_ioprio; /* See linux/ioprio.h */ > + u16 ki_write_hint; > union { > /* > * Only used for async buffered reads, where it denotes the Why 'u16'? Shouldn't this patch use the type 'enum rw_hint' for ki_write_hint and shouldn't this type be changed into u16 in a later patch? Thanks, Bart.