From: Hao Xu <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected], Joseph Qi <[email protected]>
Subject: Re: [PATCH] test/timeout-new: test for timeout feature
Date: Fri, 27 Nov 2020 11:03:12 +0800 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
在 2020/11/27 上午1:39, Jens Axboe 写道:
> On 11/23/20 12:07 AM, Hao Xu wrote:
>> Signed-off-by: Hao Xu <[email protected]>
>> ---
>>
>> Hi Jens,
>> This is a simple test for the new getevent timeout feature. Sorry for
>> the delay.
>
> We need a lot more in this test case, to be honest. Maybe test that
> it returns around 1 second? Test that if we have an event it doesn't
> wait, etc. This is as bare bones as it gets, a test case for a new
> addition/change really should test all the interesting cases around
> it.
>
Agree, I'll consider more on this.
prev parent reply other threads:[~2020-11-27 3:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 7:07 [PATCH] test/timeout-new: test for timeout feature Hao Xu
2020-11-26 12:55 ` Hao Xu
2020-11-26 17:39 ` Jens Axboe
2020-11-27 3:03 ` Hao Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a935061-c9b8-6c6f-7c38-ad99ebe341e7@linux.alibaba.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox