From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED24EC63697 for ; Fri, 27 Nov 2020 03:03:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A92B2222B for ; Fri, 27 Nov 2020 03:03:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392274AbgK0DDP (ORCPT ); Thu, 26 Nov 2020 22:03:15 -0500 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]:35240 "EHLO out30-54.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388638AbgK0DDP (ORCPT ); Thu, 26 Nov 2020 22:03:15 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=haoxu@linux.alibaba.com;NM=1;PH=DS;RN=3;SR=0;TI=SMTPD_---0UGeZIF-_1606446192; Received: from B-25KNML85-0107.local(mailfrom:haoxu@linux.alibaba.com fp:SMTPD_---0UGeZIF-_1606446192) by smtp.aliyun-inc.com(127.0.0.1); Fri, 27 Nov 2020 11:03:12 +0800 Subject: Re: [PATCH] test/timeout-new: test for timeout feature To: Jens Axboe Cc: io-uring@vger.kernel.org, Joseph Qi References: <1606115273-164396-1-git-send-email-haoxu@linux.alibaba.com> <2562fb6f-fb84-07d7-39dc-597683773e12@kernel.dk> From: Hao Xu Message-ID: <0a935061-c9b8-6c6f-7c38-ad99ebe341e7@linux.alibaba.com> Date: Fri, 27 Nov 2020 11:03:12 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <2562fb6f-fb84-07d7-39dc-597683773e12@kernel.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org 在 2020/11/27 上午1:39, Jens Axboe 写道: > On 11/23/20 12:07 AM, Hao Xu wrote: >> Signed-off-by: Hao Xu >> --- >> >> Hi Jens, >> This is a simple test for the new getevent timeout feature. Sorry for >> the delay. > > We need a lot more in this test case, to be honest. Maybe test that > it returns around 1 second? Test that if we have an event it doesn't > wait, etc. This is as bare bones as it gets, a test case for a new > addition/change really should test all the interesting cases around > it. > Agree, I'll consider more on this.