From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E740C433EF for ; Tue, 14 Sep 2021 14:53:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 016C9610A6 for ; Tue, 14 Sep 2021 14:53:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231816AbhINOym (ORCPT ); Tue, 14 Sep 2021 10:54:42 -0400 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]:44622 "EHLO out30-133.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233055AbhINOyh (ORCPT ); Tue, 14 Sep 2021 10:54:37 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=xiaoguang.wang@linux.alibaba.com;NM=1;PH=DS;RN=3;SR=0;TI=SMTPD_---0UoOlYjV_1631631197; Received: from legedeMacBook-Pro.local(mailfrom:xiaoguang.wang@linux.alibaba.com fp:SMTPD_---0UoOlYjV_1631631197) by smtp.aliyun-inc.com(127.0.0.1); Tue, 14 Sep 2021 22:53:18 +0800 Subject: Re: [PATCH] io_uring: fix missing sigmask restore in io_cqring_wait() To: Jens Axboe , io-uring@vger.kernel.org Cc: asml.silence@gmail.com References: <20210914143852.9663-1-xiaoguang.wang@linux.alibaba.com> From: Xiaoguang Wang Message-ID: <0b734068-51d8-2442-74ff-620891fc5502@linux.alibaba.com> Date: Tue, 14 Sep 2021 22:53:17 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org hi, > On 9/14/21 8:38 AM, Xiaoguang Wang wrote: >> Move get_timespec() section in io_cqring_wait() before the sigmask >> saving, otherwise we'll fail to restore sigmask once get_timespec() >> returns error. > Applied, thanks! I added a: > > Fixes: c73ebb685fb6 ("io_uring: add timeout support for io_uring_enter()") > > to the commit since that's when it got broken, that'll help with > stable backports. Not that it's a _huge_ issue, it basically means > the application is broken anyway. Agree, thanks. Regards, Xiaoguang Wang >