From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C233C433DB for ; Fri, 5 Feb 2021 10:14:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43D0864FF1 for ; Fri, 5 Feb 2021 10:14:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229972AbhBEKNm (ORCPT ); Fri, 5 Feb 2021 05:13:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229742AbhBEKLQ (ORCPT ); Fri, 5 Feb 2021 05:11:16 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 230BBC0613D6 for ; Fri, 5 Feb 2021 02:10:34 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id z6so6968158wrq.10 for ; Fri, 05 Feb 2021 02:10:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=s/p9OTUvc7EmwRy9TDJVCq1wsnd3VWA+4V6n/Zf9HBQ=; b=XUvMb4CnfzqEuPnlBsN3cjRKsqB0s1h4PHxmrtOWwPZY9m95fthUPHz2qH9ls2u9Zv zMlS7/fy6ogZVaO2twxuLrM+8pC4U15SwL/h+/43ll1s7YdjVCW4CLizLdY5q8Wp4GKy KPC4Owz8u5cQr0ur0MPiOCegapk8tTaQgiyUeDEOjPwlaz3huVvDQtjJg08EWypgtbDH h4ccu5C0S5bF7hHPaUuxWSHmf+3lkomXgOY4Tl/wPNs6oJpPQYtf3H6J6oCpL4q3N8ib LkZB5GzbqH0MpdkvKV5Aj+YMA+c/eGnP/XvsqW4Cjbk4Md6gABuwf7PHDzPuSV0Ztf9S /tnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:autocrypt:subject:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=s/p9OTUvc7EmwRy9TDJVCq1wsnd3VWA+4V6n/Zf9HBQ=; b=txxvY4lNiwkSrAK6LxmEhJHBbXc66jfl1HEletA3FGpOYPppUJa+pvvgxbIQ8bXWf+ V2in2JRdQcUs7TnsiXITA/L2yJpr8s8XWJ6OYT2KhEo25mko6Gtm8N2HEDdQMXupnLw9 ssqgoESFH8ZLJcpLSaYKxmnVmW48zwzHpf4lw9wzlJJFDDxYp88+h/B761OyTaN74KIT HkqPloUZAr0tL8RZ6N4DdkpYdn56lMj6ldSP8sm4DwhfPdxVQ6CDMtrWrLh+UbB3Ck7+ BLgLJUwbdRuWF1QKBgbfq8Uox2Qn9lJIXUVmgeISrEn5nq5zuKAjoPnGjnw/k7taWgbl Jwkg== X-Gm-Message-State: AOAM5332OGlOeFQe/VjjhfHNYjQZoXMrLoTwfzTZYAx1h5c0A87h1rVm hfzEz3QV8dwuzn/kBV+HAEQpUpSsnRqJ2g== X-Google-Smtp-Source: ABdhPJzF+qXBUwxYicJZvIQo2nOcgSCn/TTN3U/e1ThejwJrSAV6dZk1SBY1ys6exjVQBbO71zuUBA== X-Received: by 2002:adf:e4c4:: with SMTP id v4mr3943202wrm.376.1612519832762; Fri, 05 Feb 2021 02:10:32 -0800 (PST) Received: from [192.168.8.177] ([148.252.133.145]) by smtp.gmail.com with ESMTPSA id v6sm11831476wrx.32.2021.02.05.02.10.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Feb 2021 02:10:32 -0800 (PST) To: Stefan Metzmacher , Jens Axboe , io-uring@vger.kernel.org References: <3aae2e7d-0405-7f5b-9062-5eca9df13e74@gmail.com> <526757c3-49e4-33e6-5295-378a6b8c8df7@samba.org> From: Pavel Begunkov Autocrypt: addr=asml.silence@gmail.com; prefer-encrypt=mutual; keydata= mQINBFmKBOQBEAC76ZFxLAKpDw0bKQ8CEiYJRGn8MHTUhURL02/7n1t0HkKQx2K1fCXClbps bdwSHrhOWdW61pmfMbDYbTj6ZvGRvhoLWfGkzujB2wjNcbNTXIoOzJEGISHaPf6E2IQx1ik9 6uqVkK1OMb7qRvKH0i7HYP4WJzYbEWVyLiAxUj611mC9tgd73oqZ2pLYzGTqF2j6a/obaqha +hXuWTvpDQXqcOZJXIW43atprH03G1tQs7VwR21Q1eq6Yvy2ESLdc38EqCszBfQRMmKy+cfp W3U9Mb1w0L680pXrONcnlDBCN7/sghGeMHjGKfNANjPc+0hzz3rApPxpoE7HC1uRiwC4et83 CKnncH1l7zgeBT9Oa3qEiBlaa1ZCBqrA4dY+z5fWJYjMpwI1SNp37RtF8fKXbKQg+JuUjAa9 Y6oXeyEvDHMyJYMcinl6xCqCBAXPHnHmawkMMgjr3BBRzODmMr+CPVvnYe7BFYfoajzqzq+h EyXSl3aBf0IDPTqSUrhbmjj5OEOYgRW5p+mdYtY1cXeK8copmd+fd/eTkghok5li58AojCba jRjp7zVOLOjDlpxxiKhuFmpV4yWNh5JJaTbwCRSd04sCcDNlJj+TehTr+o1QiORzc2t+N5iJ NbILft19Izdn8U39T5oWiynqa1qCLgbuFtnYx1HlUq/HvAm+kwARAQABtDFQYXZlbCBCZWd1 bmtvdiAoc2lsZW5jZSkgPGFzbWwuc2lsZW5jZUBnbWFpbC5jb20+iQJOBBMBCAA4FiEE+6Ju PTjTbx479o3OWt5b1Glr+6UFAlmKBOQCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ Wt5b1Glr+6WxZA//QueaKHzgdnOikJ7NA/Vq8FmhRlwgtP0+E+w93kL+ZGLzS/cUCIjn2f4Q Mcutj2Neg0CcYPX3b2nJiKr5Vn0rjJ/suiaOa1h1KzyNTOmxnsqE5fmxOf6C6x+NKE18I5Jy xzLQoktbdDVA7JfB1itt6iWSNoOTVcvFyvfe5ggy6FSCcP+m1RlR58XxVLH+qlAvxxOeEr/e aQfUzrs7gqdSd9zQGEZo0jtuBiB7k98t9y0oC9Jz0PJdvaj1NZUgtXG9pEtww3LdeXP/TkFl HBSxVflzeoFaj4UAuy8+uve7ya/ECNCc8kk0VYaEjoVrzJcYdKP583iRhOLlZA6HEmn/+Gh9 4orG67HNiJlbFiW3whxGizWsrtFNLsSP1YrEReYk9j1SoUHHzsu+ZtNfKuHIhK0sU07G1OPN 2rDLlzUWR9Jc22INAkhVHOogOcc5ajMGhgWcBJMLCoi219HlX69LIDu3Y34uIg9QPZIC2jwr 24W0kxmK6avJr7+n4o8m6sOJvhlumSp5TSNhRiKvAHB1I2JB8Q1yZCIPzx+w1ALxuoWiCdwV M/azguU42R17IuBzK0S3hPjXpEi2sK/k4pEPnHVUv9Cu09HCNnd6BRfFGjo8M9kZvw360gC1 reeMdqGjwQ68o9x0R7NBRrtUOh48TDLXCANAg97wjPoy37dQE7e5Ag0EWYoE5AEQAMWS+aBV IJtCjwtfCOV98NamFpDEjBMrCAfLm7wZlmXy5I6o7nzzCxEw06P2rhzp1hIqkaab1kHySU7g dkpjmQ7Jjlrf6KdMP87mC/Hx4+zgVCkTQCKkIxNE76Ff3O9uTvkWCspSh9J0qPYyCaVta2D1 Sq5HZ8WFcap71iVO1f2/FEHKJNz/YTSOS/W7dxJdXl2eoj3gYX2UZNfoaVv8OXKaWslZlgqN jSg9wsTv1K73AnQKt4fFhscN9YFxhtgD/SQuOldE5Ws4UlJoaFX/yCoJL3ky2kC0WFngzwRF Yo6u/KON/o28yyP+alYRMBrN0Dm60FuVSIFafSqXoJTIjSZ6olbEoT0u17Rag8BxnxryMrgR dkccq272MaSS0eOC9K2rtvxzddohRFPcy/8bkX+t2iukTDz75KSTKO+chce62Xxdg62dpkZX xK+HeDCZ7gRNZvAbDETr6XI63hPKi891GeZqvqQVYR8e+V2725w+H1iv3THiB1tx4L2bXZDI DtMKQ5D2RvCHNdPNcZeldEoJwKoA60yg6tuUquvsLvfCwtrmVI2rL2djYxRfGNmFMrUDN1Xq F3xozA91q3iZd9OYi9G+M/OA01husBdcIzj1hu0aL+MGg4Gqk6XwjoSxVd4YT41kTU7Kk+/I 5/Nf+i88ULt6HanBYcY/+Daeo/XFABEBAAGJAjYEGAEIACAWIQT7om49ONNvHjv2jc5a3lvU aWv7pQUCWYoE5AIbDAAKCRBa3lvUaWv7pfmcEACKTRQ28b1y5ztKuLdLr79+T+LwZKHjX++P 4wKjEOECCcB6KCv3hP+J2GCXDOPZvdg/ZYZafqP68Yy8AZqkfa4qPYHmIdpODtRzZSL48kM8 LRzV8Rl7J3ItvzdBRxf4T/Zseu5U6ELiQdCUkPGsJcPIJkgPjO2ROG/ZtYa9DvnShNWPlp+R uPwPccEQPWO/NP4fJl2zwC6byjljZhW5kxYswGMLBwb5cDUZAisIukyAa8Xshdan6C2RZcNs rB3L7vsg/R8UCehxOH0C+NypG2GqjVejNZsc7bgV49EOVltS+GmGyY+moIzxsuLmT93rqyII 5rSbbcTLe6KBYcs24XEoo49Zm9oDA3jYvNpeYD8rDcnNbuZh9kTgBwFN41JHOPv0W2FEEWqe JsCwQdcOQ56rtezdCJUYmRAt3BsfjN3Jn3N6rpodi4Dkdli8HylM5iq4ooeb5VkQ7UZxbCWt UVMKkOCdFhutRmYp0mbv2e87IK4erwNHQRkHUkzbsuym8RVpAZbLzLPIYK/J3RTErL6Z99N2 m3J6pjwSJY/zNwuFPs9zGEnRO4g0BUbwGdbuvDzaq6/3OJLKohr5eLXNU3JkT+3HezydWm3W OPhauth7W0db74Qd49HXK0xe/aPrK+Cp+kU1HRactyNtF8jZQbhMCC8vMGukZtWaAwpjWiiH bA== Subject: Re: [PATCH 3/3] io_uring: refactor sendmsg/recvmsg iov managing Message-ID: <0cecc53b-aea5-354b-3aff-9bc01b784b04@gmail.com> Date: Fri, 5 Feb 2021 10:06:47 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <526757c3-49e4-33e6-5295-378a6b8c8df7@samba.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 05/02/2021 09:58, Stefan Metzmacher wrote: > Hi Pavel, > >>>> static int io_sendmsg_copy_hdr(struct io_kiocb *req, >>>> struct io_async_msghdr *iomsg) >>>> { >>>> - iomsg->iov = iomsg->fast_iov; >>>> iomsg->msg.msg_name = &iomsg->addr; >>>> + iomsg->free_iov = iomsg->fast_iov; >>> >>> Why this? Isn't the idea of this patch that free_iov is never == fast_iov? >> >> That's a part of __import_iovec() and sendmsg_copy_msghdr() API, you pass >> fast_iov as such and get back NULL or a newly allocated one in it. > I think that should at least get a comment to make this clear and > maybe a temporary variable like this: > > tmp_iov = iomsg->fast_iov; > __import_iovec(..., &tmp_iov, ...); > iomsg->free_iov = tmp_iov; I'd rather disagree. It's a well known (ish) API, and I deliberately placed such assignments right before import_iovec/etc. We have been using the same pattern has been used for reads/writes and io_import_iovec() for ages, but seems it haven't got its attention. > >>>> @@ -4872,8 +4867,8 @@ static int io_recvmsg(struct io_kiocb *req, bool force_nonblock, >>>> >>>> if (req->flags & REQ_F_BUFFER_SELECTED) >>>> cflags = io_put_recv_kbuf(req); >>>> - if (kmsg->iov != kmsg->fast_iov) >>>> - kfree(kmsg->iov); >>>> + if (kmsg->free_iov) >>>> + kfree(kmsg->free_iov); >>> >>> kfree() handles NULL, or is this a hot path and we want to avoid a function call? >> >> Yes, the hot path here is not having iov allocated, and Jens told before >> that he had observed overhead for a similar place in io_[read,write]. > > Ok, a comment would also help here... > > metze > > -- Pavel Begunkov