From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 910FEC433E6 for ; Wed, 10 Mar 2021 02:49:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61CD564FD4 for ; Wed, 10 Mar 2021 02:49:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231703AbhCJCtA (ORCPT ); Tue, 9 Mar 2021 21:49:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231464AbhCJCsz (ORCPT ); Tue, 9 Mar 2021 21:48:55 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA742C061760 for ; Tue, 9 Mar 2021 18:48:55 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id a22-20020a17090aa516b02900c1215e9b33so6395010pjq.5 for ; Tue, 09 Mar 2021 18:48:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=SSM2NdMm5I7+I/4ZH3H1cFrXbjEOIb78kT0+qdRhlMA=; b=NHJz5ikagGAMmuCe4/xpZRWTs8giri08Ra4JAEwP1fHCylgU1kTW0axqrTFJagCOCG pqOQW/YGU0maQUcsnF0fBY8Ol/yE12Us64aVk3r3a0Wb3kAkbgmpGc3Xx81AIPMFqiWR q6aFXavmyCZzBqlyUdMD0+BLUNfYzfmQc+NMwCw7wbnHzFwuF4UuXXPXQk1gr2UI7Bt6 fB1LhSXO6KTSYFYgvLRjWCvQKytja5mCPvCUSayJvE86gzMXfgHEuZ3GHYmXbbPcZqLq TYkjF80cxLSyAhr9bEf+iIrb8U9N8PW1h+LQoAy/QzeC1GWiAYaik/XddPiJ2PJlavIx DFSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SSM2NdMm5I7+I/4ZH3H1cFrXbjEOIb78kT0+qdRhlMA=; b=n/cz/9fOytIGZlAdQ9U/Nwot2D8dJIDA6nztsuQf4/uZQkbMRwWk/KbQDoxNWoavDc Is4aAmr89A0yZZiqVYXIOfhD5KKPn1x/0O4TwEucHtT/VD3pZAdIpemwvfNFehBPzGnh fdBl+b9Qk0aECWIQWtoyY5A8EyAuTkxXHRKMOX1ieoRmMFbjQjPQ59y0q7P2UnO1pZ5D aKCNK+j9iY13fQKB4pAVCu5zViVRQpOUwulRWlU9qLVqL1zdazoC9ruKRZJamh25Omk1 0BnSNiwiLT7TndiE60BK9d/HHj1eWnNwT/nvC6U6Dq9W17jYdgHjDARGlUBUune/1r0R znQQ== X-Gm-Message-State: AOAM532duWwvbIdYSwxbsGb8fpu7niYV8MjFXoeDBtK/e+3/olou0ziK ZKUpmS7M54TEIlemYO1/oOQSjw== X-Google-Smtp-Source: ABdhPJznsmRwat2YmybFdZ5bTxueFvrvVVQiG2apqCgI0KKf3BljkZ0EZcLavVVs/8YBwAlz6Cak5A== X-Received: by 2002:a17:90a:77c8:: with SMTP id e8mr1109294pjs.48.1615344535032; Tue, 09 Mar 2021 18:48:55 -0800 (PST) Received: from [192.168.1.134] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id j35sm14785971pgj.45.2021.03.09.18.48.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Mar 2021 18:48:54 -0800 (PST) Subject: Re: [v5.12-rc2 regression] io_uring: high CPU use after suspend-to-ram To: Kevin Locke , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, rafael.j.wysocki@intel.com References: From: Jens Axboe Message-ID: <0d333d67-9a3e-546d-ad1c-ecebfdbe9932@kernel.dk> Date: Tue, 9 Mar 2021 19:48:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 3/9/21 6:55 PM, Kevin Locke wrote: > With kernel 5.12-rc2 (and torvalds/master 144c79ef3353), if mpd is > playing or paused when my system is suspended-to-ram, when the system is > resumed mpd will consume ~200% CPU until killed. It continues to > produce audio and respond to pause/play commands, which do not affect > CPU usage. This occurs with either pulse (to PulseAudio or > PipeWire-as-PulseAudio) or alsa audio_output. > > The issue appears to have been introduced by a combination of two > commits: 3bfe6106693b caused freeze on suspend-to-ram when mpd is paused > or playing. e4b4a13f4941 fixed suspend-to-ram, but introduced the high > CPU on resume. > > I attempted to further diagnose using `perf record -p $(pidof mpd)`. > Running for about a minute after resume shows ~280 MMAP2 events and > almost nothing else. I'm not sure what to make of that or how to > further investigate. > > Let me know if there's anything else I can do to help diagnose/test. The below makes it work as expected for me - but I don't quite understand why we're continually running after the freeze. Adding Rafael to help understand this. Rafael, what appears to happen here from a quick look is that the io threads are frozen fine and the system suspends. But when we resume, signal_pending() is perpetually true, and that is why we then see the io_wq_manager() thread just looping like crazy. Is there anything special I need to do? Note that these are not kthreads, PF_KTHREAD is not true. I'm guessing it may have something to do with that, but haven't dug deeper yet. diff --git a/fs/io-wq.c b/fs/io-wq.c index 3d7060ba547a..0ae9ecadf295 100644 --- a/fs/io-wq.c +++ b/fs/io-wq.c @@ -591,7 +591,7 @@ static bool create_io_worker(struct io_wq *wq, struct io_wqe *wqe, int index) tsk->pf_io_worker = worker; worker->task = tsk; set_cpus_allowed_ptr(tsk, cpumask_of_node(wqe->node)); - tsk->flags |= PF_NOFREEZE | PF_NO_SETAFFINITY; + tsk->flags |= PF_NO_SETAFFINITY; raw_spin_lock_irq(&wqe->lock); hlist_nulls_add_head_rcu(&worker->nulls_node, &wqe->free_list); @@ -709,7 +709,6 @@ static int io_wq_manager(void *data) set_current_state(TASK_INTERRUPTIBLE); io_wq_check_workers(wq); schedule_timeout(HZ); - try_to_freeze(); if (fatal_signal_pending(current)) set_bit(IO_WQ_BIT_EXIT, &wq->state); } while (!test_bit(IO_WQ_BIT_EXIT, &wq->state)); diff --git a/fs/io_uring.c b/fs/io_uring.c index 280133f3abc4..8f4128eb4aa2 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -6735,7 +6735,6 @@ static int io_sq_thread(void *data) up_read(&sqd->rw_lock); schedule(); - try_to_freeze(); down_read(&sqd->rw_lock); list_for_each_entry(ctx, &sqd->ctx_list, sqd_list) io_ring_clear_wakeup_flag(ctx); diff --git a/kernel/fork.c b/kernel/fork.c index d3171e8e88e5..72e444cd0ffe 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -2436,6 +2436,7 @@ struct task_struct *create_io_thread(int (*fn)(void *), void *arg, int node) if (!IS_ERR(tsk)) { sigfillset(&tsk->blocked); sigdelsetmask(&tsk->blocked, sigmask(SIGKILL)); + tsk->flags |= PF_NOFREEZE; } return tsk; } -- Jens Axboe