From: David Wei <dw@davidwei.uk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Subject: Re: [PATCH 1/5] io_uring/zcrx: remove duplicated freelist init
Date: Fri, 18 Apr 2025 08:06:06 -0700 [thread overview]
Message-ID: <0d7e62a4-faa2-49ce-92a5-a852cca72ddc@davidwei.uk> (raw)
In-Reply-To: <27d0a2165f1890c039e873563c19c7959c1982d9.1744815316.git.asml.silence@gmail.com>
On 2025-04-16 08:21, Pavel Begunkov wrote:
> Several lines below we already initialise the freelist, don't do it
> twice.
>
> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
> ---
> io_uring/zcrx.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/io_uring/zcrx.c b/io_uring/zcrx.c
> index 5defbe8f95f9..659438f4cfcf 100644
> --- a/io_uring/zcrx.c
> +++ b/io_uring/zcrx.c
> @@ -238,9 +238,6 @@ static int io_zcrx_create_area(struct io_zcrx_ifq *ifq,
> if (!area->freelist)
> goto err;
>
> - for (i = 0; i < nr_iovs; i++)
> - area->freelist[i] = i;
> -
> area->user_refs = kvmalloc_array(nr_iovs, sizeof(area->user_refs[0]),
> GFP_KERNEL | __GFP_ZERO);
> if (!area->user_refs)
Reviewed-by: David Wei <dw@davidwei.uk>
next prev parent reply other threads:[~2025-04-18 15:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 15:21 [PATCH 0/5] add support for multiple ifqs per io_uring Pavel Begunkov
2025-04-16 15:21 ` [PATCH 1/5] io_uring/zcrx: remove duplicated freelist init Pavel Begunkov
2025-04-18 15:06 ` David Wei [this message]
2025-04-16 15:21 ` [PATCH 2/5] io_uring/zcrx: move io_zcrx_iov_page Pavel Begunkov
2025-04-18 15:07 ` David Wei
2025-04-16 15:21 ` [PATCH 3/5] io_uring/zcrx: let zcrx choose region for mmaping Pavel Begunkov
2025-04-18 15:35 ` David Wei
2025-04-18 15:52 ` Pavel Begunkov
2025-04-16 15:21 ` [PATCH 4/5] io_uring/zcrx: move zcrx region to struct io_zcrx_ifq Pavel Begunkov
2025-04-18 16:05 ` David Wei
2025-04-18 16:22 ` Pavel Begunkov
2025-04-18 18:52 ` David Wei
2025-04-16 15:21 ` [PATCH 5/5] io_uring/zcrx: add support for multiple ifqs Pavel Begunkov
2025-04-18 17:01 ` David Wei
2025-04-18 17:22 ` Pavel Begunkov
2025-04-18 18:54 ` David Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d7e62a4-faa2-49ce-92a5-a852cca72ddc@davidwei.uk \
--to=dw@davidwei.uk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox