From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BB79C61DA4 for ; Fri, 3 Feb 2023 14:25:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232717AbjBCOZ6 (ORCPT ); Fri, 3 Feb 2023 09:25:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232662AbjBCOZ5 (ORCPT ); Fri, 3 Feb 2023 09:25:57 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DF3091887 for ; Fri, 3 Feb 2023 06:25:55 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id t17so3693607pfj.0 for ; Fri, 03 Feb 2023 06:25:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YZRN1E+RhTA+olmuFS64TIGFQMQ30TCOtfaqy4X85dQ=; b=tc3c4AMu9XflukzEFjyABsrEC5buoS2hZRRluzS3tbH8Rv8PjzLMm6GeivxDOS1M+L FZ0jpXuT22i6VbU9SefXs4F2PJFVC3Bl20/ejzxRiBwQzuCe5qXlONPR03HInWtYlzQh QNq9lBC/p/+qkLikeNDbJ2vfUuQ+1S8wvTeORJA3Fla93BtS97p+1fMEMrVf5nVL4oyH RqxaRrpKYZmB4PxfUXoZG0nOtx5Dvv56eghCl+GVmqKfGF0SLqe50YUQGYkL52u0N6FE wo+0FVt56Al/tXu/ls0P+SZo6BW2txPGVeUrc57A3zs6huzjE1QjKxV/RNWaiP4UW2Sc EyiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YZRN1E+RhTA+olmuFS64TIGFQMQ30TCOtfaqy4X85dQ=; b=ksIAeivn62Z2xdIJnMTM64KthUgYz9o5uhUoTdr4JgewU7/rlNnJdpdgl7oJwtJV3y eB3xnK6y7xSrTDqrCunN1tyrhTGKZWYtUTdsRRt0p4whxDiDeArlD3qWqJ+GFvcNGHee M1Y5y+clXj8hr8A/LjXMvkuC1DrQ7slWclJZ6cGKJRZRWGlDr/LHnNOf2mELV21vBJ2Q YTXB7l8KFz0ecigAWgTlty9cDy0FI5T4Kby9zQax04IkZxfLNe9rAfbUB9u7td8GP83y QU2AFw6weg7bpeM5DlRbjaGn1OZfF1KKQjWnKNZzA4BYbVH3dpnWWdjkXSdavpliDbre EA8w== X-Gm-Message-State: AO0yUKUVk+KPABF8LO03wcXmPdxVPfQVHzRAZ48oz/4nmQIrhDzp1U5c wpWvMzyq68T4HCC5VcbP4TVtGQ== X-Google-Smtp-Source: AK7set8TFabb1k5qtX5qN3lZJoL2hYCj+bBL1/B3CNd7iFfw0RUNA/X1j3sCCNs0YC9HKRdOGLauiQ== X-Received: by 2002:a05:6a00:1d13:b0:593:b112:5cf2 with SMTP id a19-20020a056a001d1300b00593b1125cf2mr9853214pfx.2.1675434354488; Fri, 03 Feb 2023 06:25:54 -0800 (PST) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id k12-20020aa790cc000000b00592543d7363sm1798250pfk.1.2023.02.03.06.25.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Feb 2023 06:25:54 -0800 (PST) Message-ID: <0da4031f-6706-87ef-b888-ead7c5814193@kernel.dk> Date: Fri, 3 Feb 2023 07:25:53 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: =?UTF-8?Q?Re=3a_=5bregression=5d_Bug=c2=a0216932_-_io=5furing_with_?= =?UTF-8?Q?libvirt_cause_kernel_NULL_pointer_dereference_since_6=2e1=2e5?= Content-Language: en-US To: Greg Kroah-Hartman Cc: Linux regressions mailing list , "stable@vger.kernel.org" , io-uring@vger.kernel.org, LKML , "Sergey V." References: <74347fe1-ac68-2661-500d-b87fab6994f7@leemhuis.info> <0857ddf2-89a9-231b-89da-57cacc7342d5@kernel.dk> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 2/3/23 2:17 AM, Greg Kroah-Hartman wrote: > On Mon, Jan 16, 2023 at 08:50:20AM -0700, Jens Axboe wrote: >> On 1/16/23 8:44 AM, Jens Axboe wrote: >>> On 1/16/23 7:49 AM, Greg Kroah-Hartman wrote: >>>> On Mon, Jan 16, 2023 at 07:13:40AM -0700, Jens Axboe wrote: >>>>> On 1/16/23 6:42 AM, Jens Axboe wrote: >>>>>> On 1/16/23 6:17?AM, Linux kernel regression tracking (Thorsten Leemhuis) wrote: >>>>>>> Hi, this is your Linux kernel regression tracker. >>>>>>> >>>>>>> I noticed a regression report in bugzilla.kernel.org. As many (most?) >>>>>>> kernel developer don't keep an eye on it, I decided to forward it by >>>>>>> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216932 : >>>>>> >>>>>> Looks like: >>>>>> >>>>>> commit 6d47e0f6a535701134d950db65eb8fe1edf0b575 >>>>>> Author: Jens Axboe >>>>>> Date: Wed Jan 4 08:52:06 2023 -0700 >>>>>> >>>>>> block: don't allow splitting of a REQ_NOWAIT bio >>>>>> >>>>>> got picked up by stable, but not the required prep patch: >>>>>> >>>>>> >>>>>> commit 613b14884b8595e20b9fac4126bf627313827fbe >>>>>> Author: Jens Axboe >>>>>> Date: Wed Jan 4 08:51:19 2023 -0700 >>>>>> >>>>>> block: handle bio_split_to_limits() NULL return >>>>>> >>>>>> Greg/team, can you pick the latter too? It'll pick cleanly for >>>>>> 6.1-stable, not sure how far back the other patch has gone yet. >>>>> >>>>> Looked back, and 5.15 has it too, but the cherry-pick won't work >>>>> on that kernel. >>>>> >>>>> Here's one for 5.15-stable that I verified crashes before this one, >>>>> and works with it. Haven't done an allmodconfig yet... >>>> >>>> All now queued up, thanks! >>> >>> Thanks Greg! This one was my fault, as it was a set of 2 patches and >>> I only marked 2/2 for stable. But how is that best handled? 1/2 could've >>> been marked stable as well, but I don't think that would have prevented >>> 2/2 applying fine and 1/2 failing and hence not getting queued up until >>> I would've done a backport. >>> >>> What's the recommended way to describe the dependency that you only >>> want 2/2 applied when 1/2 is in as well? >> >> What I'm asking is if we have something like Depends-on or similar >> that would explain this dependency. Then patch 2/2 could have: >> >> Depends-on: 613b14884b85 ("block: handle bio_split_to_limits() NULL return") >> >> and then it'd be clear that either both get added, or none of them. > > As per the documentation, you can put this on the cc: stable line in the > changelog text like: > cc: stable # 613b14884b85 Gotcha, will try and remember that :-) -- Jens Axboe