From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 985351362; Mon, 1 Apr 2024 03:41:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.190 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711942883; cv=none; b=cBdL2RuEzA/koJRdUPuV6T2xqU70H2ACc/v2somBMvRqirbeRVbyER34qTexEsgTcT5fgO1Whr177Sm7mJ5gsUcKRb7jbnMOauzNAlFqDioSlqAlnkiTcYS2Pko5LNE+SsD46o3rcQmYD5RrI5M1pVE8O9jYiNhiuMvdDLxtUac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711942883; c=relaxed/simple; bh=Y+C6YOutpzawaB9+UJw3qAWVjD/gimExt0e/uFbsI/M=; h=Subject:To:CC:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=mY7Zk+TlqPu+lrZp7JFB4o4xRLuTe0T0l5lwKEyf/RlZzxfTwzOgGUlk8z4t+NoeFia2/2U+Fo20XeD6iK7KPJdITlUistow2/yNUhTmp+S6Q2SNpTnNIHVbMnJEUrRSLoNWXULJForu/DemB62v3kznoGkHCly12w2wz5N6ENM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.190 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4V7Gvt1Wpsz1xtQy; Mon, 1 Apr 2024 11:39:06 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id C7BCE1A016F; Mon, 1 Apr 2024 11:41:11 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 1 Apr 2024 11:41:10 +0800 Subject: Re: [PATCH 1/7] memory: Remove the now superfluous sentinel element from ctl_table array To: CC: Luis Chamberlain , , , , , , , , , , , Andrew Morton , Muchun Song , Naoya Horiguchi , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , David Howells , Jarkko Sakkinen , Kees Cook , Herbert Xu , "David S. Miller" , Jens Axboe , Pavel Begunkov , Atish Patra , Anup Patel , Will Deacon , Mark Rutland , Paul Walmsley , Palmer Dabbelt , Albert Ou References: <20240328-jag-sysctl_remset_misc-v1-0-47c1463b3af2@samsung.com> <20240328-jag-sysctl_remset_misc-v1-1-47c1463b3af2@samsung.com> From: Miaohe Lin Message-ID: <0e35e88d-3ea1-4f62-77e4-eb12e9f51583@huawei.com> Date: Mon, 1 Apr 2024 11:41:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240328-jag-sysctl_remset_misc-v1-1-47c1463b3af2@samsung.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500002.china.huawei.com (7.192.104.244) On 2024/3/28 23:57, Joel Granados via B4 Relay wrote: > From: Joel Granados > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which will > reduce the overall build time size of the kernel and run time memory > bloat by ~64 bytes per sentinel (further information Link : > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/) > > Remove sentinel from all files under mm/ that register a sysctl table. > > Signed-off-by: Joel Granados Reviewed-by: Miaohe Lin Thanks. > --- > mm/compaction.c | 1 - > mm/hugetlb.c | 1 - > mm/hugetlb_vmemmap.c | 1 - > mm/memory-failure.c | 1 - > mm/oom_kill.c | 1 - > mm/page-writeback.c | 1 - > mm/page_alloc.c | 1 - > 7 files changed, 7 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 807b58e6eb68..e8a047afca22 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -3345,7 +3345,6 @@ static struct ctl_table vm_compaction[] = { > .extra1 = SYSCTL_ZERO, > .extra2 = SYSCTL_ONE, > }, > - { } > }; > > static int __init kcompactd_init(void) > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 23ef240ba48a..7ac5240a197d 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -5045,7 +5045,6 @@ static struct ctl_table hugetlb_table[] = { > .mode = 0644, > .proc_handler = hugetlb_overcommit_handler, > }, > - { } > }; > > static void hugetlb_sysctl_init(void) > diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c > index da177e49d956..b9a55322e52c 100644 > --- a/mm/hugetlb_vmemmap.c > +++ b/mm/hugetlb_vmemmap.c > @@ -679,7 +679,6 @@ static struct ctl_table hugetlb_vmemmap_sysctls[] = { > .mode = 0644, > .proc_handler = proc_dobool, > }, > - { } > }; > > static int __init hugetlb_vmemmap_init(void) > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 9349948f1abf..6a112f9ecf91 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -141,7 +141,6 @@ static struct ctl_table memory_failure_table[] = { > .extra1 = SYSCTL_ZERO, > .extra2 = SYSCTL_ONE, > }, > - { } > }; > > /* > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 8d6a207c3c59..4d7a0004df2c 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -724,7 +724,6 @@ static struct ctl_table vm_oom_kill_table[] = { > .mode = 0644, > .proc_handler = proc_dointvec, > }, > - {} > }; > #endif > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index 3e19b87049db..fba324e1a010 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -2291,7 +2291,6 @@ static struct ctl_table vm_page_writeback_sysctls[] = { > .mode = 0644, > .proc_handler = proc_dointvec_jiffies, > }, > - {} > }; > #endif > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 14d39f34d336..8b9820620fe3 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6211,7 +6211,6 @@ static struct ctl_table page_alloc_sysctl_table[] = { > .extra2 = SYSCTL_ONE_HUNDRED, > }, > #endif > - {} > }; > > void __init page_alloc_sysctl_init(void) >