* [PATCH] io_uring: clear req->result on IOPOLL re-issue
@ 2020-08-27 1:38 Jens Axboe
0 siblings, 0 replies; only message in thread
From: Jens Axboe @ 2020-08-27 1:38 UTC (permalink / raw)
To: io-uring
Make sure we clear req->result, which was set to -EAGAIN for retry
purposes, when moving it to the reissue list. Otherwise we can end up
retrying a request more than once, which leads to weird results in
the io-wq handling (and other spots).
Cc: [email protected]
Reported-by: Andres Freund <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
---
diff --git a/fs/io_uring.c b/fs/io_uring.c
index bd2d8de3f2e8..6df08287c59e 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2049,6 +2049,7 @@ static void io_iopoll_complete(struct io_ring_ctx *ctx, unsigned int *nr_events,
req = list_first_entry(done, struct io_kiocb, inflight_entry);
if (READ_ONCE(req->result) == -EAGAIN) {
+ req->result = 0;
req->iopoll_completed = 0;
list_move_tail(&req->inflight_entry, &again);
continue;
--
Jens Axboe
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-08-27 1:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-27 1:38 [PATCH] io_uring: clear req->result on IOPOLL re-issue Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox