From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Subject: Re: [PATCH 5.12 v3] io_uring: fix rw req completion
Date: Sat, 10 Apr 2021 20:30:02 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 4/10/21 6:31 PM, Pavel Begunkov wrote:
> On 08/04/2021 19:28, Pavel Begunkov wrote:
>> WARNING: at fs/io_uring.c:8578 io_ring_exit_work.cold+0x0/0x18
>>
>> As reissuing is now passed back by REQ_F_REISSUE and kiocb_done()
>> internally uses __io_complete_rw(), it may stop after setting the flag
>> so leaving a dangling request.
>>
>> There are tricky edge cases, e.g. reading beyound file, boundary, so
>> the easiest way is to hand code reissue in kiocb_done() as
>> __io_complete_rw() was doing for us before.
>
> fwiw, was using this fixed up version for 5.13
Thanks, I'm going to rebase (again...) and fold in when -rc7 is out.
--
Jens Axboe
prev parent reply other threads:[~2021-04-11 2:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 18:28 [PATCH 5.12 v3] io_uring: fix rw req completion Pavel Begunkov
2021-04-08 18:33 ` Pavel Begunkov
2021-04-08 19:33 ` Jens Axboe
2021-04-11 0:31 ` Pavel Begunkov
2021-04-11 2:30 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox