From: Jens Axboe <[email protected]>
To: Christoph Hellwig <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [PATCH 2/3] block: mark bdev files as FMODE_NOWAIT if underlying device supports it
Date: Tue, 20 Jun 2023 08:56:07 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 6/20/23 7:29?AM, Christoph Hellwig wrote:
> On Tue, Jun 20, 2023 at 07:24:56AM -0600, Jens Axboe wrote:
>> I think we need stronger justification than that, it's much nicer to
>> have it in the open path than doing the same check over and over for
>> each IO.
>>
>> With your new proposed scheme, why can't the check and FMODE_NOWAIT set
>> still be in open?
>
> Because I want to move the by now huge number of static flags out of
> file->f_mode and into file->f_op.flags. It's just that with this patch
> this one flag isn't static anymore for block devices. We could also
> do two sets of file operations assuming we never allow run-time changes
> for QUEUE_FLAG_NOWAIT. If we care about optimizing fo async I/O on the
> few drivers not supporting QUEUE_FLAG_NOWAIT that's probably the next
> best thing.
Doing two sets of fops makes sense to me, and then hopefully down the
line we can shave it down to 1 again once everything sets FMODE_NOWAIT.
--
Jens Axboe
next prev parent reply other threads:[~2023-06-20 14:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 15:19 [PATCHSET 0/3] Improve FMODE_NOWAIT coverage Jens Axboe
2023-05-09 15:19 ` [PATCH 1/3] net: set FMODE_NOWAIT for sockets Jens Axboe
2023-05-11 8:03 ` Paolo Abeni
2023-05-11 13:30 ` Jens Axboe
2023-05-09 15:19 ` [PATCH 2/3] block: mark bdev files as FMODE_NOWAIT if underlying device supports it Jens Axboe
2023-05-10 13:30 ` Christoph Hellwig
2023-05-10 15:32 ` Jens Axboe
2023-06-20 6:18 ` Christoph Hellwig
2023-06-20 8:22 ` Christoph Hellwig
2023-06-20 13:24 ` Jens Axboe
2023-06-20 13:29 ` Christoph Hellwig
2023-06-20 14:56 ` Jens Axboe [this message]
2023-05-09 15:19 ` [PATCH 3/3] io_uring: rely solely on FMODE_NOWAIT Jens Axboe
2023-05-09 16:48 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox