From: Jens Axboe <axboe@kernel.dk>
To: Christian Brauner <brauner@kernel.org>
Cc: io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/5] eventpoll: add file based control interface
Date: Tue, 12 May 2026 14:03:23 -0600 [thread overview]
Message-ID: <0eed0ed6-7e56-4dc2-acbf-7a221012e08a@kernel.dk> (raw)
In-Reply-To: <177861542130.846060.12151691690322065378.b4-review@b4>
On 5/12/26 1:50 PM, Christian Brauner wrote:
> On Sun, 03 May 2026 02:49:14 -0600, Jens Axboe <axboe@kernel.dk> wrote:
>> diff --git a/include/linux/eventpoll.h b/include/linux/eventpoll.h
>> index 7bf30e9f90d7..4a6fe989810b 100644
>> --- a/include/linux/eventpoll.h
>> +++ b/include/linux/eventpoll.h
>> @@ -61,6 +61,13 @@ static inline void eventpoll_release(struct file *file)
>> eventpoll_release_file(file);
>> }
>>
>> +struct epoll_filefd {
>> + struct file *file;
>> + int fd;
>> +} __packed;
>
> Since you're exposing this in a header now can we please rename this to:
>
> struct epoll_key
>
> This weird {file, fd} pairing is strange enough as it is.
I'm all for that, but let's do that as another cleanup on top. This way
we can keep this one purely mechanical.
--
Jens Axboe
next prev parent reply other threads:[~2026-05-12 20:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 8:49 [PATCHSET 0/5] io_uring related epoll cleanups Jens Axboe
2026-05-03 8:49 ` [PATCH 1/5] eventpoll: pass struct epoll_filefd through ep_find() and ep_insert() Jens Axboe
2026-05-12 19:50 ` Christian Brauner
2026-05-03 8:49 ` [PATCH 2/5] eventpoll: export is_file_epoll() Jens Axboe
2026-05-12 19:50 ` Christian Brauner
2026-05-03 8:49 ` [PATCH 3/5] eventpoll: add file based control interface Jens Axboe
2026-05-12 19:50 ` Christian Brauner
2026-05-12 20:03 ` Jens Axboe [this message]
2026-05-03 8:49 ` [PATCH 4/5] io_uring/epoll: switch to using do_epoll_ctl_file() interface Jens Axboe
2026-05-03 8:49 ` [PATCH 5/5] io_uring/epoll: disallow adding an epoll file to an epoll context Jens Axboe
2026-05-12 19:50 ` Christian Brauner
2026-05-12 20:04 ` Jens Axboe
2026-05-12 19:50 ` [PATCHSET 0/5] io_uring related epoll cleanups Christian Brauner
2026-05-12 20:04 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0eed0ed6-7e56-4dc2-acbf-7a221012e08a@kernel.dk \
--to=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox