From: Pavel Begunkov <asml.silence@gmail.com>
To: Bertie Tryner <bertietryner@gmail.com>, io-uring@vger.kernel.org
Cc: axboe@kernel.dk, Bertie Tryner <Bertie.Tryner@warwick.ac.uk>
Subject: Re: [PATCH v2] io_uring/zcrx: reorder fd allocation in zcrx_export()
Date: Wed, 8 Apr 2026 09:43:20 +0100 [thread overview]
Message-ID: <0ffa9a2f-e3d6-4f0d-b6ee-3c84fcaace5d@gmail.com> (raw)
In-Reply-To: <20260406165846.94517-1-Bertie.Tryner@warwick.ac.uk>
On 4/6/26 17:58, Bertie Tryner wrote:
> Currently, zcrx_export() allocates a file descriptor and copies the
> control structure to userspace before the backing file is created.
>
> While the operation returns an error on failure, it is cleaner to
> follow the standard kernel pattern of performing the copy_to_user()
> and fd_install() only after all resource allocations (like the
> anon_inode) have succeeded. This aligns the code with other
> fd-publishing paths in the VFS.
I don't believe we care about it, to be honest, but I'll take a
look later after 7.1 is released.
--
Pavel Begunkov
prev parent reply other threads:[~2026-04-08 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 16:58 [PATCH v2] io_uring/zcrx: reorder fd allocation in zcrx_export() Bertie Tryner
2026-04-08 8:43 ` Pavel Begunkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ffa9a2f-e3d6-4f0d-b6ee-3c84fcaace5d@gmail.com \
--to=asml.silence@gmail.com \
--cc=Bertie.Tryner@warwick.ac.uk \
--cc=axboe@kernel.dk \
--cc=bertietryner@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox