From: Yu Kuai <[email protected]>
To: Ming Lei <[email protected]>, Guangwu Zhang <[email protected]>
Cc: Yu Kuai <[email protected]>, Jens Axboe <[email protected]>,
[email protected], [email protected],
Jeff Moyer <[email protected]>, Jan Kara <[email protected]>,
Paolo Valente <[email protected]>,
"yukuai (C)" <[email protected]>
Subject: Re: [bug report] BUG: kernel NULL pointer dereference, address: 0000000000000048
Date: Wed, 10 May 2023 14:55:14 +0800 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <ZFs8G9RmHLYZ2Q0N@fedora>
Hi,
在 2023/05/10 14:39, Ming Lei 写道:
> On Wed, May 10, 2023 at 12:05:07PM +0800, Guangwu Zhang wrote:
>> HI,
>> after apply your patch[1], the system will panic after reboot.
This is werid, I just reporduce this problem in my VM, and I verified
this patch can fix the problem.
Anyway, Ming's patch looks better, you can try it.
Thanks,
Kuai
>>
>
> Maybe you can try the following patch?
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index f6dad0886a2f..d84174a7e997 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -1303,7 +1303,7 @@ void blk_execute_rq_nowait(struct request *rq, bool at_head)
> * device, directly accessing the plug instead of using blk_mq_plug()
> * should not have any consequences.
> */
> - if (current->plug && !at_head) {
> + if (current->plug && !at_head && rq->bio) {
> blk_add_rq_to_plug(current->plug, rq);
> return;
> }
>
>
> thanks,
> Ming
>
> .
>
next prev parent reply other threads:[~2023-05-10 6:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 0:49 [bug report] BUG: kernel NULL pointer dereference, address: 0000000000000048 Guangwu Zhang
2023-05-10 1:29 ` Yu Kuai
2023-05-10 1:49 ` Yu Kuai
2023-05-10 2:00 ` Yu Kuai
2023-05-10 2:17 ` Jens Axboe
2023-05-10 3:20 ` Yu Kuai
[not found] ` <CAGS2=YocNy9PkgRzzRdHAK1gGdjMxzA--PYS=sPrX_nCe4U6QA@mail.gmail.com>
2023-05-10 6:39 ` Ming Lei
2023-05-10 6:55 ` Yu Kuai [this message]
2023-05-10 12:08 ` Guangwu Zhang
2023-05-10 4:52 ` Guangwu Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=109a1c64-ab81-b719-6913-600d78e3f10c@huaweicloud.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox