From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Subject: Re: [PATCH v4 2/2] test/splice: add basic splice tests
Date: Mon, 24 Feb 2020 09:07:28 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <b4a11a08d6c6fe7c3292eac3d1eb9fb9f8f9d7dd.1582560081.git.asml.silence@gmail.com>
On 2/24/20 9:03 AM, Pavel Begunkov wrote:
> Signed-off-by: Pavel Begunkov <[email protected]>
Two things I'd like to see changed:
- Any error print should go to stderr, not stdout
- Should pass on kernels that don't have splice, the usual way there
is to detect the -EINVAL and say that the test was skipped.
--
Jens Axboe
prev parent reply other threads:[~2020-02-24 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 16:03 [PATCH RESEND v4 0/2] splice helpers + tests Pavel Begunkov
2020-02-24 16:03 ` [PATCH v4 1/2] splice: add splice(2) helpers Pavel Begunkov
2020-02-24 16:03 ` [PATCH v4 2/2] test/splice: add basic splice tests Pavel Begunkov
2020-02-24 16:07 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox