From: Jens Axboe <[email protected]>
To: Dylan Yudaken <[email protected]>,
Pavel Begunkov <[email protected]>,
[email protected]
Cc: [email protected], kernel test robot <[email protected]>
Subject: Re: [PATCH] io_uring: fix io_recvmsg_prep_multishot casts
Date: Fri, 5 Aug 2022 08:41:15 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 8/5/22 5:54 AM, Dylan Yudaken wrote:
> Fix casts missing the __user parts. This seemed to only cause errors on
> the alpha build, but it was definitely an oversight.
>
> Reported-by: kernel test robot <[email protected]>
> Fixes: 9bb66906f23e ("io_uring: support multishot in recvmsg")
> Signed-off-by: Dylan Yudaken <[email protected]>
> ---
>
> Hi,
>
> I tried to reproduce this issue to be sure this fixes it, but I could not get the
> warnings out of the gcc I have locally.
> That being said it seems like a fairly clear fix.
If you do:
axboe@m1 ~/gi/linux-block (io_uring-6.0)> make C=1 io_uring/net.o
o_uring/net.c: note: in included file (through io_uring/io_uring.h):
io_uring/slist.h:138:29: warning: no newline at end of file
io_uring/net.c:579:44: warning: incorrect type in assignment (different address spaces)
io_uring/net.c:579:44: expected void [noderef] __user *msg_control_user
io_uring/net.c:579:44: got void *
io_uring/net.c:584:14: warning: incorrect type in assignment (different address spaces)
io_uring/net.c:584:14: expected void [noderef] __user *
io_uring/net.c:584:14: got void *
it'll show it, you need 'sparse' installed for that.
--
Jens Axboe
next prev parent reply other threads:[~2022-08-05 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 11:54 [PATCH] io_uring: fix io_recvmsg_prep_multishot casts Dylan Yudaken
2022-08-05 14:41 ` Jens Axboe [this message]
2022-08-05 14:41 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox