* [PATCH for-next] io_uring/net: don't continue send bundle if poll was required for retry
@ 2026-01-28 4:05 Jens Axboe
0 siblings, 0 replies; only message in thread
From: Jens Axboe @ 2026-01-28 4:05 UTC (permalink / raw)
To: io-uring
If a send bundle has picked a bunch of buffers, then it needs to send
all of those to be complete. This may require poll arming, if the send
buffer ends up being full. Once a send bundle has been poll armed, no
further bundles should be attempted.
This allows a current bundle to complete even though it needs to go
through polling to do so, but it will not allow another bundle to be
started once that has happened. Ideally we would abort a bundle if it
was only partially sent, but as some parts of it already went out on the
wire, this obviously isn't feasible. Not continuing more bundle attempts
post encountering a full socket buffer is the second best thing.
Cc: stable@vger.kernel.org
Fixes: a05d1f625c7a ("io_uring/net: support bundles for send")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
This supersedes the previous kbuf/send bundle fixes sent.
diff --git a/io_uring/net.c b/io_uring/net.c
index 519ea055b761..1778fa028471 100644
--- a/io_uring/net.c
+++ b/io_uring/net.c
@@ -515,7 +515,7 @@ static inline bool io_send_finish(struct io_kiocb *req,
cflags = io_put_kbufs(req, sel->val, sel->buf_list, io_bundle_nbufs(kmsg, sel->val));
- if (bundle_finished || req->flags & REQ_F_BL_EMPTY)
+ if (bundle_finished || req->flags & (REQ_F_BL_EMPTY | REQ_F_POLLED))
goto finish;
/*
--
Jens Axboe
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-01-28 4:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-28 4:05 [PATCH for-next] io_uring/net: don't continue send bundle if poll was required for retry Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox