From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF19DC433DF for ; Thu, 18 Jun 2020 20:04:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 849C720890 for ; Thu, 18 Jun 2020 20:04:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lightnvm-io.20150623.gappssmtp.com header.i=@lightnvm-io.20150623.gappssmtp.com header.b="2Gdw9yRp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730872AbgFRUEd (ORCPT ); Thu, 18 Jun 2020 16:04:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729580AbgFRUEc (ORCPT ); Thu, 18 Jun 2020 16:04:32 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09EA8C06174E for ; Thu, 18 Jun 2020 13:04:32 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id h5so7423330wrc.7 for ; Thu, 18 Jun 2020 13:04:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=I1X5PgsyDNPZk5OWUMSkw5d9tqtI+lNZgxN4Rtom3J4=; b=2Gdw9yRpfZxYdJPIxo9vBo6m73ZCsO3/13tXY2w0ZeHHFdt4gSwy/htURFqSmKf4WG Vcu9QN/YTZ8yD20PpRBi2W1z9zQBycqw9+em7uYgosUj77O6ve0zOSJs284LnMXdtYhn raSPvaaJmx6EOie8eiwOIaUwDTyRibfq+uyl0nMTuqAj04owC7YOwYJQGxu9i0SnmkzT 2VCWv0KyTnidlmyeG4wxlx3uYNHsIuFDXcCpRD0+tr2hg6Yjg8u33PjfrIqzNiZyCkoI oX5Mi2IywJXrc9KfaI9U+c895gh2SuZBZcFsJfzIBvxwGQrR4BHtcFQVeNUFXa81ZQ34 hG4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=I1X5PgsyDNPZk5OWUMSkw5d9tqtI+lNZgxN4Rtom3J4=; b=PharWzr5LaxRiveRcsqPrDDWbTUv3Yfl58VBrJRl3slPa6pFo6o0mNc+oBekJBQbY+ fTVTy/eYOiEpWmz9cPdlFDlcegDcjM+SQrfcWN58HuPDzkap6PR0+oqUkQE0gKi2aoHm 8nRpGgbrh9iFs1qXtcbr+GE/TJbpK+bfmTkDFQbS3r9cdjlv2tQIsvThVmMNXaZVWX2c PyXLcFK2mBZoMMzCXxEhCS+9TP4EudiuAg6L5y7PmfwpKZU8zfk5XtAzKfcMonVEKLcT B1F2QvtOoMcoG1gc8O6+ZKtPTyucb10Paem7LjOuxbiF5dgbXYSnQFM8xj2HLa3esjCA xsMg== X-Gm-Message-State: AOAM533Q/xxNPEwnmIEBDfg14oUiimmiqcEknGu2VfYMZU7CqP7lehE3 DGrD2aKbDZZzLesCfY3p2O97gQ== X-Google-Smtp-Source: ABdhPJxevHzd88MB3BtvBcSHFDfduqy63NdjLXzwRNfLfbeBHu+X/bIxcZVe6+j+aB1WA/b3mWH6NQ== X-Received: by 2002:adf:fd81:: with SMTP id d1mr206028wrr.96.1592510670761; Thu, 18 Jun 2020 13:04:30 -0700 (PDT) Received: from [10.0.0.6] (xb932c246.cust.hiper.dk. [185.50.194.70]) by smtp.gmail.com with ESMTPSA id e2sm2750197wrt.76.2020.06.18.13.04.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 13:04:30 -0700 (PDT) Subject: Re: [PATCH 0/3] zone-append support in aio and io-uring To: Kanchan Joshi Cc: axboe@kernel.dk, viro@zeniv.linux.org.uk, bcrl@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-aio@kvack.org, io-uring@vger.kernel.org, linux-block@vger.kernel.org, selvakuma.s1@samsung.com, nj.shetty@samsung.com, javier.gonz@samsung.com, Damien Le Moal , Keith Busch , Christoph Hellwig References: <1592414619-5646-1-git-send-email-joshi.k@samsung.com> <20200618192153.GA4141485@test-zns> From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <12a630ce-599b-3877-8079-10b319b55d45@lightnvm.io> Date: Thu, 18 Jun 2020 22:04:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200618192153.GA4141485@test-zns> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 18/06/2020 21.21, Kanchan Joshi wrote: > On Thu, Jun 18, 2020 at 10:04:32AM +0200, Matias Bjørling wrote: >> On 17/06/2020 19.23, Kanchan Joshi wrote: >>> This patchset enables issuing zone-append using aio and io-uring >>> direct-io interface. >>> >>> For aio, this introduces opcode IOCB_CMD_ZONE_APPEND. Application >>> uses start LBA >>> of the zone to issue append. On completion 'res2' field is used to >>> return >>> zone-relative offset. >>> >>> For io-uring, this introduces three opcodes: >>> IORING_OP_ZONE_APPEND/APPENDV/APPENDV_FIXED. >>> Since io_uring does not have aio-like res2, cqe->flags are >>> repurposed to return zone-relative offset >> >> Please provide a pointers to applications that are updated and ready >> to take advantage of zone append. >> >> I do not believe it's beneficial at this point to change the libaio >> API, applications that would want to use this API, should anyway >> switch to use io_uring. >> >> Please also note that applications and libraries that want to take >> advantage of zone append, can already use the zonefs file-system, as >> it will use the zone append command when applicable. > > AFAIK, zonefs uses append while serving synchronous I/O. And append bio > is waited upon synchronously. That maybe serving some purpose I do > not know currently. But it seems applications using zonefs file > abstraction will get benefitted if they could use the append > themselves to > carry the I/O, asynchronously. Yep, please see Christoph's comment regarding adding the support to zonefs.