From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04254C433DB for ; Wed, 3 Feb 2021 23:00:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE55164DFD for ; Wed, 3 Feb 2021 23:00:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233276AbhBCXA1 (ORCPT ); Wed, 3 Feb 2021 18:00:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233406AbhBCW7Q (ORCPT ); Wed, 3 Feb 2021 17:59:16 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EA44C0613D6 for ; Wed, 3 Feb 2021 14:58:36 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id gx20so605988pjb.1 for ; Wed, 03 Feb 2021 14:58:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VI8+mzDznZXreI3+hxAHs7jNdKbUG8fpqNw3FQx4Z28=; b=UVoUQSB0BgEs5PAHR/kMD4pwba+L48QIxB2rizTswy/5XS+jhWrgdCb4UeKh+zlcsz OO2hpOlqyiHdkiky9nIqrTT7+roUHaqCpK2yZgiqEL+0pSRIohqnS0pqNASRy8yiRljK T18i5UJJ2R1Qx/UrpgflkjEaSA81xQ2L6aXYFwaI8xeuBr/Ssl+sMoP3B4MJT/l9FGu7 Qy2f3fo1wgPzh8+F/c+oqKZb/pYBIWaoNAktj4X2f84TWOq0G6Q+TouvQvrNIIOU/tX8 FiK2jm+uQW6XMOUAm7qJIA/lqCT2GTRogVgF9SpSKqMxTnIZm69FineNnIlnnn5kDi1S v9nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VI8+mzDznZXreI3+hxAHs7jNdKbUG8fpqNw3FQx4Z28=; b=YcBk2YQVS+MdjNW4NdMozLpeTxzzWz2UVahWbfI33lWuSkNOMJlPiDXW7s5UiTYLNA IbB/pxsfZAxmLC5NMZYDmT4S0g4bmHQ4h1pMAf6zG2tzV35XnP8575BANtyn9BZS9S0P 11a7hNDeVdlX10U2Fm0CymFYDMEAuEbODWPSSOrBvlU6DZXE+5EQz14duskcmwBSDdNW wPeM7CNRT7G/lolV3oGCkNyq1XbOvhWaHq8Fbvp3qB2f62RY0xfRYDuBGB+Y16rQnWgK UfUzM7T4QqXJENyxjFcN8gWskYxyEQm5zw+uBGZ9O5kJbZT6E7VDpBegpuepsUxAPZUS O8xQ== X-Gm-Message-State: AOAM533Q/uvEcAkcESX10gMJl5IgFGdJnAUGdox7jFV15OlfizA+YK9a JObNdidntyW798h1qUH5sAOAEA== X-Google-Smtp-Source: ABdhPJyop9GAWs+kkwennI5HB0WYgw78vTEm4XM9Qe8GmO4mKRhSXGccKwJBdxJGlb0a31OASOG+9g== X-Received: by 2002:a17:90a:7ace:: with SMTP id b14mr5383372pjl.208.1612393115474; Wed, 03 Feb 2021 14:58:35 -0800 (PST) Received: from [192.168.1.134] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id z15sm102697pjz.41.2021.02.03.14.58.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Feb 2021 14:58:34 -0800 (PST) Subject: Re: [PATCH 5.4 103/142] Revert "block: end bio with BLK_STS_AGAIN in case of non-mq devs and REQ_NOWAIT" To: Greg Kroah-Hartman , Andres Freund Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Bijan Mottahedeh , Sasha Levin References: <20200601174037.904070960@linuxfoundation.org> <20200601174048.647302799@linuxfoundation.org> <20210203123729.3pfsakawrkoh6qpu@alap3.anarazel.de> <20210203212826.6esa5orgnworwel6@alap3.anarazel.de> From: Jens Axboe Message-ID: <14351e91-5a5f-d742-b087-dc9ec733bbfd@kernel.dk> Date: Wed, 3 Feb 2021 15:58:33 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 2/3/21 3:06 PM, Greg Kroah-Hartman wrote: > On Wed, Feb 03, 2021 at 01:28:26PM -0800, Andres Freund wrote: >> Hi, >> >> On 2021-02-03 14:03:09 +0100, Greg Kroah-Hartman wrote: >>>> On v5.4.43-101-gbba91cdba612 this fails with >>>> fio: io_u error on file /mnt/t2/test.0.0: Input/output error: write offset=0, buflen=4096 >>>> fio: pid=734, err=5/file:io_u.c:1834, func=io_u error, error=Input/output error >>>> >>>> whereas previously it worked. libaio still works... >>>> >>>> I haven't checked which major kernel version fixed this again, but I did >>>> verify that it's still broken in 5.4.94 and that 5.10.9 works. >>>> >>>> I would suspect it's >>>> >>>> commit 4503b7676a2e0abe69c2f2c0d8b03aec53f2f048 >>>> Author: Jens Axboe >>>> Date: 2020-06-01 10:00:27 -0600 >>>> >>>> io_uring: catch -EIO from buffered issue request failure >>>> >>>> -EIO bubbles up like -EAGAIN if we fail to allocate a request at the >>>> lower level. Play it safe and treat it like -EAGAIN in terms of sync >>>> retry, to avoid passing back an errant -EIO. >>>> >>>> Catch some of these early for block based file, as non-mq devices >>>> generally do not support NOWAIT. That saves us some overhead by >>>> not first trying, then retrying from async context. We can go straight >>>> to async punt instead. >>>> >>>> Signed-off-by: Jens Axboe >>>> >>>> >>>> which isn't in stable/linux-5.4.y >>> >>> Can you test that if the above commit is added, all works well again? >> >> It doesn't apply cleanly, I'll try to resolve the conflict. However, I >> assume that the revert was for a concrete reason - but I can't quite >> figure out what b0beb28097fa04177b3769f4bb7a0d0d9c4ae76e was concretely >> solving, and whether reverting the revert in 5.4 would re-introduce a >> different problem. >> >> commit b0beb28097fa04177b3769f4bb7a0d0d9c4ae76e (tag: block-5.7-2020-05-29, linux-block/block-5.7) >> Author: Jens Axboe >> Date: 2020-05-28 13:19:29 -0600 >> >> Revert "block: end bio with BLK_STS_AGAIN in case of non-mq devs and REQ_NOWAIT" >> >> This reverts commit c58c1f83436b501d45d4050fd1296d71a9760bcb. >> >> io_uring does do the right thing for this case, and we're still returning >> -EAGAIN to userspace for the cases we don't support. Revert this change >> to avoid doing endless spins of resubmits. >> >> Cc: stable@vger.kernel.org # v5.6 >> Reported-by: Bijan Mottahedeh >> Signed-off-by: Jens Axboe >> >> I suspect it just wasn't aimed at 5.4, and that's that, but I'm not >> sure. In which case presumably reverting >> bba91cdba612fbce4f8575c5d94d2b146fb83ea3 would be the right fix, not >> backporting 4503b7676a2e0abe69c2f2c0d8b03aec53f2f048 et al. > > Ok, can you send a revert patch for this? > > But it would be good to get Jens to weigh in on this... I'll take a look at this. -- Jens Axboe