From: Olivier Langlois <[email protected]>
To: Jens Axboe <[email protected]>,Pavel Begunkov
<[email protected]>,[email protected]
Subject: [PATCH] io_uring/napi: remove duplicate io_napi_entry timeout assignation
Date: Sun, 11 Aug 2024 20:34:46 -0400 [thread overview]
Message-ID: <145b54ff179f87609e20dffaf5563c07cdbcad1a.1723423275.git.olivier@trillion01.com> (raw)
io_napi_entry() has 2 calling sites. One of them is unlikely to find an
entry and if it does, the timeout should arguable not be updated.
The other io_napi_entry() calling site is overwriting the update made
by io_napi_entry() so the io_napi_entry() timeout value update has no or
little value and therefore is removed.
Signed-off-by: Olivier Langlois <[email protected]>
---
io_uring/napi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/io_uring/napi.c b/io_uring/napi.c
index 73c4159e8405..1de1d4d62925 100644
--- a/io_uring/napi.c
+++ b/io_uring/napi.c
@@ -26,7 +26,6 @@ static struct io_napi_entry *io_napi_hash_find(struct hlist_head *hash_list,
hlist_for_each_entry_rcu(e, hash_list, node) {
if (e->napi_id != napi_id)
continue;
- e->timeout = jiffies + NAPI_TIMEOUT;
return e;
}
--
2.46.0
next reply other threads:[~2024-08-12 0:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 0:34 Olivier Langlois [this message]
2024-08-12 1:00 ` [PATCH] io_uring/napi: remove duplicate io_napi_entry timeout assignation Olivier Langlois
2024-08-12 18:10 ` Jens Axboe
2024-08-12 18:11 ` Jens Axboe
2024-08-12 20:15 ` Olivier Langlois
2024-08-12 20:40 ` Jens Axboe
2024-08-12 21:39 ` Olivier Langlois
2024-08-12 21:45 ` Olivier Langlois
2024-08-12 21:50 ` Jens Axboe
2024-08-13 17:22 ` Olivier Langlois
2024-08-13 18:35 ` Jens Axboe
2024-08-14 0:09 ` Olivier Langlois
2024-08-14 0:31 ` Jens Axboe
2024-08-14 0:44 ` Pavel Begunkov
2024-08-12 18:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=145b54ff179f87609e20dffaf5563c07cdbcad1a.1723423275.git.olivier@trillion01.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox