From: Pavel Begunkov <asml.silence@gmail.com>
To: io-uring@vger.kernel.org
Cc: asml.silence@gmail.com, axboe@kernel.dk,
Dylan Yudaken <dyudaken@gmail.com>
Subject: [PATCH 1/3] io_uring/zctx: rename flags var for more clarity
Date: Mon, 16 Feb 2026 11:45:53 +0000 [thread overview]
Message-ID: <14b3c62803fe22e2b29fb4fc9648fb1a08e53f72.1771240334.git.asml.silence@gmail.com> (raw)
In-Reply-To: <cover.1771240334.git.asml.silence@gmail.com>
The name "flags" is too overloaded, so rename the variable in
io_sendmsg_zc() into msg_flags to stress that it contains MSG_*.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
io_uring/net.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/io_uring/net.c b/io_uring/net.c
index 8576c6cb2236..5f7f02e2c034 100644
--- a/io_uring/net.c
+++ b/io_uring/net.c
@@ -1524,7 +1524,7 @@ int io_sendmsg_zc(struct io_kiocb *req, unsigned int issue_flags)
struct io_sr_msg *sr = io_kiocb_to_cmd(req, struct io_sr_msg);
struct io_async_msghdr *kmsg = req->async_data;
struct socket *sock;
- unsigned flags;
+ unsigned msg_flags;
int ret, min_ret = 0;
if (req->flags & REQ_F_IMPORT_BUFFER) {
@@ -1550,21 +1550,21 @@ int io_sendmsg_zc(struct io_kiocb *req, unsigned int issue_flags)
(sr->flags & IORING_RECVSEND_POLL_FIRST))
return -EAGAIN;
- flags = sr->msg_flags;
+ msg_flags = sr->msg_flags;
if (issue_flags & IO_URING_F_NONBLOCK)
- flags |= MSG_DONTWAIT;
- if (flags & MSG_WAITALL)
+ msg_flags |= MSG_DONTWAIT;
+ if (msg_flags & MSG_WAITALL)
min_ret = iov_iter_count(&kmsg->msg.msg_iter);
kmsg->msg.msg_control_user = sr->msg_control;
kmsg->msg.msg_ubuf = &io_notif_to_data(sr->notif)->uarg;
- ret = __sys_sendmsg_sock(sock, &kmsg->msg, flags);
+ ret = __sys_sendmsg_sock(sock, &kmsg->msg, msg_flags);
if (unlikely(ret < min_ret)) {
if (ret == -EAGAIN && (issue_flags & IO_URING_F_NONBLOCK))
return -EAGAIN;
- if (ret > 0 && io_net_retry(sock, flags)) {
+ if (ret > 0 && io_net_retry(sock, msg_flags)) {
sr->done_io += ret;
return -EAGAIN;
}
--
2.52.0
next prev parent reply other threads:[~2026-02-16 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 11:45 [PATCH 0/3] deduplicate send and senmsg zc issue handlers Pavel Begunkov
2026-02-16 11:45 ` Pavel Begunkov [this message]
2026-02-16 11:45 ` [PATCH 2/3] io_uring/zctx: move vec regbuf import into io_send_zc_import Pavel Begunkov
2026-02-16 11:45 ` [PATCH 3/3] io_uring/zctx: unify zerocopy issue variants Pavel Begunkov
2026-02-16 16:35 ` [PATCH 0/3] deduplicate send and senmsg zc issue handlers Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14b3c62803fe22e2b29fb4fc9648fb1a08e53f72.1771240334.git.asml.silence@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=dyudaken@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox