public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jiufei Xue <[email protected]>
To: [email protected]
Cc: [email protected], [email protected]
Subject: [PATCH] io_uring: don't set REQ_F_NOWAIT for regular files opend O_NONBLOCK
Date: Fri, 29 May 2020 15:18:28 +0800	[thread overview]
Message-ID: <[email protected]> (raw)

When read from a regular file that was opened O_NONBLOCK, it will
return EAGAIN if the page is not cached, which is not expected and
fails the application.

Applications written before expect that the open flag O_NONBLOCK has
no effect on a regular file.

Fix this by not setting REQ_F_NOWAIT for regular files.

Signed-off-by: Jiufei Xue <[email protected]>
---
 fs/io_uring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 95df63b..69db8bb 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2107,7 +2107,7 @@ static int io_prep_rw(struct io_kiocb *req, const struct io_uring_sqe *sqe,
 
 	/* don't allow async punt if RWF_NOWAIT was requested */
 	if ((kiocb->ki_flags & IOCB_NOWAIT) ||
-	    (req->file->f_flags & O_NONBLOCK))
+	    (!(req->flags & REQ_F_ISREG) && (req->file->f_flags & O_NONBLOCK)))
 		req->flags |= REQ_F_NOWAIT;
 
 	if (force_nonblock)
-- 
1.8.3.1


             reply	other threads:[~2020-05-29  7:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-29  7:18 Jiufei Xue [this message]
2020-05-29 14:20 ` [PATCH] io_uring: don't set REQ_F_NOWAIT for regular files opend O_NONBLOCK Jens Axboe
2020-06-01  3:26   ` Jiufei Xue
2020-06-10  6:16     ` Jiufei Xue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1590736708-99812-1-git-send-email-jiufei.xue@linux.alibaba.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox