From: Pavel Begunkov <[email protected]>
To: Dmitry Kadashev <[email protected]>
Cc: Jens Axboe <[email protected]>,
Alexander Viro <[email protected]>,
Christian Brauner <[email protected]>,
[email protected],
io-uring <[email protected]>
Subject: Re: [PATCH v5 02/10] io_uring: add support for IORING_OP_MKDIRAT
Date: Wed, 23 Jun 2021 12:53:49 +0100 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAOKbgA4ZwzUxyRxWrF7iC2sNVnEwXXAmrxVSsSxBMQRe2OyYVQ@mail.gmail.com>
On 6/23/21 7:41 AM, Dmitry Kadashev wrote:
> On Tue, Jun 22, 2021 at 6:50 PM Pavel Begunkov <[email protected]> wrote:
>>
>> On 6/22/21 12:41 PM, Pavel Begunkov wrote:
>>> On 6/3/21 6:18 AM, Dmitry Kadashev wrote:
>>>> IORING_OP_MKDIRAT behaves like mkdirat(2) and takes the same flags
>>>> and arguments.
>>>>
>>>> Signed-off-by: Dmitry Kadashev <[email protected]>
>>>> ---
[...]
>>> We have to check unused fields, e.g. buf_index and off,
>>> to be able to use them in the future if needed.
>>>
>>> if (sqe->buf_index || sqe->off)
>>> return -EINVAL;
>>>
>>> Please double check what fields are not used, and
>>> same goes for all other opcodes.
>
> This changeset is based on some other ops that were added a while ago
> (renameat, unlinkat), which lack the check as well. I guess I'll just go over
That's not great... Thanks for letting know
> all of them and add the checks in a single patch if that's OK.
For newly added opcodes a single patch on top is ok, rename and
unlink should be patched separately.
> I'd imagine READ_ONCE is to be used in those checks though, isn't it? Some of
> the existing checks like this lack it too btw. I suppose I can fix those in a
> separate commit if that makes sense.
When we really use a field there should be a READ_ONCE(),
but I wouldn't care about those we check for compatibility
reasons, but that's only my opinion.
>> + opcode specific flags, e.g.
>>
>> if (sqe->rw_flags)
>> return -EINVAL;
>
--
Pavel Begunkov
next prev parent reply other threads:[~2021-06-23 11:54 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 5:18 [PATCH v5 00/10] io_uring: add mkdir, [sym]linkat and mknodat support Dmitry Kadashev
2021-06-03 5:18 ` [PATCH v5 01/10] fs: make do_mkdirat() take struct filename Dmitry Kadashev
2021-06-03 5:18 ` [PATCH v5 02/10] io_uring: add support for IORING_OP_MKDIRAT Dmitry Kadashev
2021-06-22 11:41 ` Pavel Begunkov
2021-06-22 11:50 ` Pavel Begunkov
2021-06-23 6:41 ` Dmitry Kadashev
2021-06-23 11:53 ` Pavel Begunkov [this message]
2021-06-24 11:11 ` Dmitry Kadashev
2021-06-24 12:21 ` Pavel Begunkov
2021-06-28 8:17 ` Dmitry Kadashev
2021-07-07 14:06 ` Pavel Begunkov
2021-07-12 12:44 ` Dmitry Kadashev
2021-07-12 13:14 ` Pavel Begunkov
2021-06-22 17:41 ` Pavel Begunkov
2021-06-23 0:41 ` Jens Axboe
2021-06-23 5:50 ` Dmitry Kadashev
2021-06-03 5:18 ` [PATCH v5 03/10] fs: make do_mknodat() take struct filename Dmitry Kadashev
2021-06-03 5:18 ` [PATCH v5 04/10] fs: make do_symlinkat() " Dmitry Kadashev
2021-06-03 5:18 ` [PATCH v5 05/10] namei: add getname_uflags() Dmitry Kadashev
2021-06-03 5:18 ` [PATCH v5 06/10] fs: make do_linkat() take struct filename Dmitry Kadashev
2021-06-03 5:18 ` [PATCH v5 07/10] fs: update do_*() helpers to return ints Dmitry Kadashev
2021-06-03 5:18 ` [PATCH v5 08/10] io_uring: add support for IORING_OP_SYMLINKAT Dmitry Kadashev
2021-06-22 11:36 ` Pavel Begunkov
2021-06-23 5:45 ` Dmitry Kadashev
2021-06-03 5:18 ` [PATCH v5 09/10] io_uring: add support for IORING_OP_LINKAT Dmitry Kadashev
2021-06-22 11:48 ` Pavel Begunkov
2021-06-23 6:09 ` Dmitry Kadashev
2021-06-23 13:13 ` Pavel Begunkov
2021-06-03 5:18 ` [PATCH v5 10/10] io_uring: add support for IORING_OP_MKNODAT Dmitry Kadashev
2021-06-22 11:52 ` Pavel Begunkov
2021-06-23 6:26 ` Dmitry Kadashev
2021-06-23 11:58 ` Pavel Begunkov
2021-06-24 2:36 ` Jens Axboe
2021-06-18 6:24 ` [PATCH v5 00/10] io_uring: add mkdir, [sym]linkat and mknodat support Dmitry Kadashev
2021-06-18 16:10 ` Jens Axboe
2021-06-21 15:21 ` Jens Axboe
2021-06-22 8:12 ` Christian Brauner
2021-06-22 8:34 ` Dmitry Kadashev
2021-06-29 13:06 ` Christian Brauner
2021-06-22 17:26 ` Jens Axboe
2021-06-22 8:26 ` Dmitry Kadashev
2021-06-21 15:57 ` Jens Axboe
2021-06-21 15:59 ` Jens Axboe
2021-06-22 11:56 ` Pavel Begunkov
2021-06-22 17:26 ` Jens Axboe
2021-06-22 17:28 ` Pavel Begunkov
2021-06-22 17:32 ` Jens Axboe
2021-06-23 5:37 ` Dmitry Kadashev
2021-06-23 5:49 ` Dmitry Kadashev
2021-06-24 2:37 ` Jens Axboe
2021-06-24 10:55 ` Dmitry Kadashev
2021-06-23 5:35 ` Dmitry Kadashev
2021-06-24 2:37 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox