public inbox for [email protected]
 help / color / mirror / Atom feed
From: Bijan Mottahedeh <[email protected]>
To: [email protected], [email protected], [email protected]
Subject: [PATCH v4 00/13] io_uring: buffer registration enhancements
Date: Wed,  6 Jan 2021 12:39:09 -0800	[thread overview]
Message-ID: <[email protected]> (raw)

v4:

- address v3 comments (TBD REGISTER_BUFFERS)
- rebase

v3:

- batch file->rsrc renames into a signle patch when possible
- fix other review changes from v2
- fix checkpatch warnings

v2:

- drop readv/writev with fixed buffers patch
- handle ref_nodes both both files/buffers with a single ref_list
- make file/buffer handling more unified

This patchset implements a set of enhancements to buffer registration
consistent with existing file registration functionality:

- buffer registration updates		IORING_REGISTER_BUFFERS_UPDATE
					IORING_OP_BUFFERS_UPDATE

- buffer registration sharing		IORING_SETUP_SHARE_BUF
					IORING_SETUP_ATTACH_BUF

I have kept the original patchset unchanged for the most part to
facilitate reviewing and so this set adds a number of additional patches
mostly making file/buffer handling more unified.

Patch 1-2 modularize existing buffer registration code.

Patch 3-7 generalize fixed_file functionality to fixed_rsrc.

Patch 8 applies fixed_rsrc functionality for fixed buffers support.

Patch 9-10 generalize files_update functionality to rsrc_update.

Patch 11 implements buffer registration update, and introduces
IORING_REGISTER_BUFFERS_UPDATE and IORING_OP_BUFFERS_UPDATE, consistent
with file registration update.

Patch 12 generalizes fixed resource allocation 

Patch 13 implements buffer sharing among multiple rings; it works as follows:

- A new ring, A,  is setup. Since no buffers have been registered, the
  registered buffer state is an empty set, Z. That's different from the
  NULL state in current implementation.

- Ring B is setup, attaching to Ring A. It's also attaching to it's
  buffer registrations, now we have two references to the same empty
  set, Z.

- Ring A registers buffers into set Z, which is no longer empty.

- Ring B sees this immediately, since it's already sharing that set.

Testing

I have used liburing file-{register,update} tests as models for
buffer-{register,update,share}, tests and they run ok.

TBD

- I tried to use a single opcode for files/buffers but ran into an
issue since work_flags is different for files/buffers.  This should
be ok for the most part since req->work.flags is ultimately examined;
however, there are place where io_op_defs[opcode].work_flags is examined
directly, and I wasn't sure what would the best way to handle that.

- Need to still address Pavel's comments about deadlocks. I figure
to send out the set anyway since this is a last patch and may even be
handled separately.

Bijan Mottahedeh (13):
  io_uring: modularize io_sqe_buffer_register
  io_uring: modularize io_sqe_buffers_register
  io_uring: rename file related variables to rsrc
  io_uring: generalize io_queue_rsrc_removal
  io_uring: separate ref_list from fixed_rsrc_data
  io_uring: split alloc_fixed_file_ref_node
  io_uring: add rsrc_ref locking routines
  io_uring: implement fixed buffers registration similar to fixed files
  io_uring: create common fixed_rsrc_ref_node handling routines
  io_uring: generalize files_update functionlity to rsrc_update
  io_uring: support buffer registration updates
  io_uring: create common fixed_rsrc_data allocation routines
  io_uring: support buffer registration sharing

 fs/io_uring.c                 | 1002 +++++++++++++++++++++++++++++------------
 include/uapi/linux/io_uring.h |   13 +-
 2 files changed, 733 insertions(+), 282 deletions(-)

-- 
1.8.3.1


             reply	other threads:[~2021-01-06 20:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06 20:39 Bijan Mottahedeh [this message]
2021-01-06 20:39 ` [PATCH v4 01/13] io_uring: modularize io_sqe_buffer_register Bijan Mottahedeh
2021-01-06 20:39 ` [PATCH v4 02/13] io_uring: modularize io_sqe_buffers_register Bijan Mottahedeh
2021-01-06 20:39 ` [PATCH v4 03/13] io_uring: rename file related variables to rsrc Bijan Mottahedeh
2021-01-06 20:39 ` [PATCH v4 04/13] io_uring: generalize io_queue_rsrc_removal Bijan Mottahedeh
2021-01-06 20:39 ` [PATCH v4 05/13] io_uring: separate ref_list from fixed_rsrc_data Bijan Mottahedeh
2021-01-06 20:39 ` [PATCH v4 06/13] io_uring: split alloc_fixed_file_ref_node Bijan Mottahedeh
2021-01-06 20:39 ` [PATCH v4 07/13] io_uring: add rsrc_ref locking routines Bijan Mottahedeh
2021-01-06 20:39 ` [PATCH v4 08/13] io_uring: implement fixed buffers registration similar to fixed files Bijan Mottahedeh
2021-01-06 20:39 ` [PATCH v4 09/13] io_uring: create common fixed_rsrc_ref_node handling routines Bijan Mottahedeh
2021-01-08  1:57   ` Bijan Mottahedeh
2021-01-06 20:39 ` [PATCH v4 10/13] io_uring: generalize files_update functionlity to rsrc_update Bijan Mottahedeh
2021-01-06 20:39 ` [PATCH v4 11/13] io_uring: support buffer registration updates Bijan Mottahedeh
2021-01-06 20:39 ` [PATCH v4 12/13] io_uring: create common fixed_rsrc_data allocation routines Bijan Mottahedeh
2021-01-06 20:39 ` [PATCH v4 13/13] io_uring: support buffer registration sharing Bijan Mottahedeh
2021-01-07 15:53 ` [PATCH v4 00/13] io_uring: buffer registration enhancements Jens Axboe
2021-01-07 17:03   ` Bijan Mottahedeh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1609965562-13569-1-git-send-email-bijan.mottahedeh@oracle.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox