From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26531C4321A for ; Wed, 6 Jan 2021 20:40:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6B402311B for ; Wed, 6 Jan 2021 20:40:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726794AbhAFUkO (ORCPT ); Wed, 6 Jan 2021 15:40:14 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:54910 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726960AbhAFUkO (ORCPT ); Wed, 6 Jan 2021 15:40:14 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 106KYwT5052622; Wed, 6 Jan 2021 20:39:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id; s=corp-2020-01-29; bh=23jsOayRQJqNTySENyV1nvH3OCnrYJMGgN7zO42dQwI=; b=zShNuwJbVtlstn0FN8WqkrmFYiWEMuUrEDbYzlF/RWrn4TRVPYhTK2je7CM6MHpx+rnU tguhlNF3HMF9BrAgU0QhhpCfXDwVElqjBEgcc/fyTLBUqpSO/FMrRijp1EaT0TFUfes6 X8aZT4ChOlh34FdcYx7eQMFm0UHc/K3PGDHKxar66cVJO6c/RqpDxvIqv4WyjG+SFokG KiqUjTD5Dfpu60Vtr8Yt4Q387clfvBler+l1XIbgjOvKsjfe5nc70x6OrTywqmj6Falw Q9ru+IRvn0lXtBYzmztmnrLwT7tBB57evt9BeVWgPjUUZm36tmuXab7XmzjmonWKp65S TA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 35wepm9s2e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 06 Jan 2021 20:39:32 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 106KaUw6178140; Wed, 6 Jan 2021 20:39:32 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 35v4rd3tvq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 06 Jan 2021 20:39:31 +0000 Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 106KdUZP021561; Wed, 6 Jan 2021 20:39:30 GMT Received: from ca-ldom147.us.oracle.com (/10.129.68.131) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 06 Jan 2021 20:39:30 +0000 From: Bijan Mottahedeh To: axboe@kernel.dk, asml.silence@gmail.com, io-uring@vger.kernel.org Subject: [PATCH v4 00/13] io_uring: buffer registration enhancements Date: Wed, 6 Jan 2021 12:39:09 -0800 Message-Id: <1609965562-13569-1-git-send-email-bijan.mottahedeh@oracle.com> X-Mailer: git-send-email 1.8.3.1 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9856 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 bulkscore=0 suspectscore=0 spamscore=0 adultscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101060117 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9856 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 spamscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 clxscore=1015 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101060117 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org v4: - address v3 comments (TBD REGISTER_BUFFERS) - rebase v3: - batch file->rsrc renames into a signle patch when possible - fix other review changes from v2 - fix checkpatch warnings v2: - drop readv/writev with fixed buffers patch - handle ref_nodes both both files/buffers with a single ref_list - make file/buffer handling more unified This patchset implements a set of enhancements to buffer registration consistent with existing file registration functionality: - buffer registration updates IORING_REGISTER_BUFFERS_UPDATE IORING_OP_BUFFERS_UPDATE - buffer registration sharing IORING_SETUP_SHARE_BUF IORING_SETUP_ATTACH_BUF I have kept the original patchset unchanged for the most part to facilitate reviewing and so this set adds a number of additional patches mostly making file/buffer handling more unified. Patch 1-2 modularize existing buffer registration code. Patch 3-7 generalize fixed_file functionality to fixed_rsrc. Patch 8 applies fixed_rsrc functionality for fixed buffers support. Patch 9-10 generalize files_update functionality to rsrc_update. Patch 11 implements buffer registration update, and introduces IORING_REGISTER_BUFFERS_UPDATE and IORING_OP_BUFFERS_UPDATE, consistent with file registration update. Patch 12 generalizes fixed resource allocation Patch 13 implements buffer sharing among multiple rings; it works as follows: - A new ring, A, is setup. Since no buffers have been registered, the registered buffer state is an empty set, Z. That's different from the NULL state in current implementation. - Ring B is setup, attaching to Ring A. It's also attaching to it's buffer registrations, now we have two references to the same empty set, Z. - Ring A registers buffers into set Z, which is no longer empty. - Ring B sees this immediately, since it's already sharing that set. Testing I have used liburing file-{register,update} tests as models for buffer-{register,update,share}, tests and they run ok. TBD - I tried to use a single opcode for files/buffers but ran into an issue since work_flags is different for files/buffers. This should be ok for the most part since req->work.flags is ultimately examined; however, there are place where io_op_defs[opcode].work_flags is examined directly, and I wasn't sure what would the best way to handle that. - Need to still address Pavel's comments about deadlocks. I figure to send out the set anyway since this is a last patch and may even be handled separately. Bijan Mottahedeh (13): io_uring: modularize io_sqe_buffer_register io_uring: modularize io_sqe_buffers_register io_uring: rename file related variables to rsrc io_uring: generalize io_queue_rsrc_removal io_uring: separate ref_list from fixed_rsrc_data io_uring: split alloc_fixed_file_ref_node io_uring: add rsrc_ref locking routines io_uring: implement fixed buffers registration similar to fixed files io_uring: create common fixed_rsrc_ref_node handling routines io_uring: generalize files_update functionlity to rsrc_update io_uring: support buffer registration updates io_uring: create common fixed_rsrc_data allocation routines io_uring: support buffer registration sharing fs/io_uring.c | 1002 +++++++++++++++++++++++++++++------------ include/uapi/linux/io_uring.h | 13 +- 2 files changed, 733 insertions(+), 282 deletions(-) -- 1.8.3.1